Closed Bug 1423015 Opened 8 years ago Closed 8 years ago

Desktop not receiving "fxaccounts:device_disconnected" push notifications

Categories

(Cloud Services :: Server: Firefox Accounts, defect)

Product:
Cloud Services
Component:
Server: Firefox Accounts
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: markh, Assigned: rfkelly)

References

Details

I've been able to reproduce this 100% of the time in around 10 attempts over the last day. Thom has reproduce it once. Ed has offered to try and repro tomorrow. STR: * Have 2 desktop devices connected to the same FxA account and running. * On one device use FxA to disconnect the other. Expected: * The disconnected device gets a push notification that completely disconnects sync. Actual: * The disconnected device continues to sync until the token server token expires, then enters a regular "please reconnect" state (ie, the state described in bug 1422679) IOW: * Bug 1422679 is the fact that desktop doesn't quite do the right thing if a push fails to arrive. * This bug is about the push failing to arrive.
IIUC, we used to send the push notification before actually deleting the device, so that it would arrive at all devices including the one being disconnected. As of this PR: https://github.com/mozilla/fxa-auth-server/pull/2086/files We now do the opposite - delete the device record, then send the push notification. That means that we don't actually send the push notification to the device that got disconnected. I don't recall the motivation for the above change; :eoger do you recall whether this change to no longer notify the disconnected device was intentional, or an unintended side-effect of the above?
Flags: needinfo?(eoger)
Assuming we do in fact want to send this notification to the disconnected device, the fix seems pretty straightforward: generate the list of devices to send to before we action the delete: https://github.com/mozilla/fxa-auth-server/pull/2245
Definitely a side effect. The PR you opened looks alright to me since we now work with Device records directly.
Flags: needinfo?(eoger)
Being fixed in github - thanks! Assigning to Ryan for him to close when the train leaves the station.
Assignee: nobody → rfkelly
The fix for this should now be live.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.