1423069 - Put js/src/jit-test/tests/typedobject/bug-1415313.js into js/src/jit-test/tests/TypedObject.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[James Cheng[:JamesCheng]]

I don't have the permission to look into Bug 1415313.

https://hg.mozilla.org/mozilla-central/rev/2d8ec1c6eb16

It seems "bug-141531.js" is located in a "typedobject" folder instead of the "/js/src/jit-test/tests/TypedObject/"

Is it possible to merge into "TypedObject"?

It makes my "case-insensitive" disk (Mac) with a strange behavior using git...

After rebasing to central,

$ git status
On branch master
Untracked files:  (use "git add ..." to include in what will be committed)	js/src/jit-test/tests/TypedObject/bug-1415313.js

I cannot erase this record by any operation....

Does anyone meet this issue?

Comment 1

[James Cheng[:JamesCheng]]

Attachment: 0001-Move-file-into-TypedObject.patch

Does the patch make sense?

Thanks

Comment 2

[Jan de Mooij [:jandem]]

Why is this bug marked mozilla-employee-confidential?

I wonder if our prevent_case_only_renames Mercurial hook will allow this kind of change.

Comment 3

[James Cheng[:JamesCheng]]

Because Bug 1415313 is a security bug...

I'm afraid of revealing any information.

Feel free to unset the "mozilla-employee-confidential" if you think it's not necessary!

Comment 4

[Jan de Mooij [:jandem]]

Ah I see. This bug does not reveal any extra information so it's fine to unhide it :)

Comment 5

[Gregory Szorc [:gps]]

We actually don't have the hook to prevent case-only renames enabled. There's an old bug tracking that. It slipped off my radar because badness happens so rarely.

Renaming the directory will cause issues for people with case insensitive filesystems. So my preference is to avoid the rename.

The issue only occurs when doing an incremental working directory update. So if you want to perform a case-only rename with minimal disruption, you can do an initial non-case-only rename. Wait a few weeks. Then rename to the case-colliding name.

Comment 6

[James Cheng[:JamesCheng]]

Hi kvijayan, 

Are you able to review the patch?

If you are busy right now, would you please transfer the review request to an appropriate one?

Thanks

Comment 7

[Jason Orendorff [:jorendorff]]

Comment on attachment 8934389 [details] [diff] [review]
0001-Move-file-into-TypedObject.patch

Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c1f6b71b705
Move file into TypedObject. r=jorendorff

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/7c1f6b71b705