Closed Bug 1423094 Opened 2 years ago Closed 2 years ago

Remove xpcom_staticruntime and mozalloc_staticruntime

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(5 files)

No description provided.
Attachment #8934411 - Flags: review?(core-build-config-reviews) → review?(gps)
Attachment #8934412 - Flags: review?(core-build-config-reviews) → review?(gps)
Attachment #8934413 - Flags: review?(core-build-config-reviews) → review?(gps)
Attachment #8934414 - Flags: review?(core-build-config-reviews) → review?(gps)
Attachment #8934422 - Flags: review?(core-build-config-reviews) → review?(gps)
Comment on attachment 8934411 [details]
Bug 1423094 - Remove last use of msvcrt='static'.

https://reviewboard.mozilla.org/r/205332/#review211208
Attachment #8934411 - Flags: review?(gps) → review+
Comment on attachment 8934412 [details]
Bug 1423094 - Remove the msvcrt argument to GeckoProgram.

https://reviewboard.mozilla.org/r/205334/#review211210
Attachment #8934412 - Flags: review?(gps) → review+
Comment on attachment 8934413 [details]
Bug 1423094 - Remove mozalloc_staticruntime.

https://reviewboard.mozilla.org/r/205336/#review211212
Attachment #8934413 - Flags: review?(gps) → review+
Comment on attachment 8934414 [details]
Bug 1423094 - Remove xpcom_staticruntime.

https://reviewboard.mozilla.org/r/205338/#review211216
Attachment #8934414 - Flags: review?(gps) → review+
Comment on attachment 8934422 [details]
Bug 1423094 - Remove USE_STATIC_LIBS=True-related code in mozalloc.

https://reviewboard.mozilla.org/r/205346/#review211218

Nice cleanup.

Please do write a little bit more in the bug report or commit messages next time. I had to poke around a bit more than normal during this review because things weren't spelled out clearly.
Attachment #8934422 - Flags: review?(gps) → review+
hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 5 changesets with 6 changes to 6 files
remote: autoland push detected
remote: recorded push in pushlog
remote: replication log not available; cannot close transaction
remote: transaction abort!
remote: rolling back pushlog
remote: rollback completed
remote: pretxnclose.vcsreplicator hook failed
abort: push failed on remote
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/1d5425c6c059
Remove last use of msvcrt='static'. r=gps
https://hg.mozilla.org/integration/autoland/rev/6b169a883cbf
Remove the msvcrt argument to GeckoProgram. r=gps
https://hg.mozilla.org/integration/autoland/rev/732c2765dc44
Remove mozalloc_staticruntime. r=gps
https://hg.mozilla.org/integration/autoland/rev/012bb0ef8621
Remove xpcom_staticruntime. r=gps
https://hg.mozilla.org/integration/autoland/rev/16dda9d15c06
Remove USE_STATIC_LIBS=True-related code in mozalloc. r=gps
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.