1423094 - Remove xpcom_staticruntime and mozalloc_staticruntime

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1423094 - Remove last use of msvcrt='static'.

Review commit: https://reviewboard.mozilla.org/r/205332/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205332/

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1423094 - Remove the msvcrt argument to GeckoProgram.

The last use in gecko was removed in the previous change, and the only
use in comm-central should be trivial to remove. It's not worth the
extra complexity to keep this argument.

Review commit: https://reviewboard.mozilla.org/r/205334/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205334/

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1423094 - Remove mozalloc_staticruntime.

Review commit: https://reviewboard.mozilla.org/r/205336/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205336/

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1423094 - Remove xpcom_staticruntime.

Review commit: https://reviewboard.mozilla.org/r/205338/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205338/

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1423094 - Remove USE_STATIC_LIBS=True-related code in mozalloc.

Review commit: https://reviewboard.mozilla.org/r/205346/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205346/

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 8934411 [details]
Bug 1423094 - Remove last use of msvcrt='static'.

https://reviewboard.mozilla.org/r/205332/#review211208

Comment 7

[Gregory Szorc [:gps]]

Comment on attachment 8934412 [details]
Bug 1423094 - Remove the msvcrt argument to GeckoProgram.

https://reviewboard.mozilla.org/r/205334/#review211210

Comment 8

[Gregory Szorc [:gps]]

Comment on attachment 8934413 [details]
Bug 1423094 - Remove mozalloc_staticruntime.

https://reviewboard.mozilla.org/r/205336/#review211212

Comment 9

[Gregory Szorc [:gps]]

Comment on attachment 8934414 [details]
Bug 1423094 - Remove xpcom_staticruntime.

https://reviewboard.mozilla.org/r/205338/#review211216

Comment 10

[Gregory Szorc [:gps]]

Comment on attachment 8934422 [details]
Bug 1423094 - Remove USE_STATIC_LIBS=True-related code in mozalloc.

https://reviewboard.mozilla.org/r/205346/#review211218

Nice cleanup.

Please do write a little bit more in the bug report or commit messages next time. I had to poke around a bit more than normal during this review because things weren't spelled out clearly.

Comment 11

[Mozilla Autoland]

hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 5 changesets with 6 changes to 6 files
remote: autoland push detected
remote: recorded push in pushlog
remote: replication log not available; cannot close transaction
remote: transaction abort!
remote: rolling back pushlog
remote: rollback completed
remote: pretxnclose.vcsreplicator hook failed
abort: push failed on remote

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d5425c6c059
Remove last use of msvcrt='static'. r=gps
https://hg.mozilla.org/integration/autoland/rev/6b169a883cbf
Remove the msvcrt argument to GeckoProgram. r=gps
https://hg.mozilla.org/integration/autoland/rev/732c2765dc44
Remove mozalloc_staticruntime. r=gps
https://hg.mozilla.org/integration/autoland/rev/012bb0ef8621
Remove xpcom_staticruntime. r=gps
https://hg.mozilla.org/integration/autoland/rev/16dda9d15c06
Remove USE_STATIC_LIBS=True-related code in mozalloc. r=gps

Comment 13

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/1d5425c6c059
https://hg.mozilla.org/mozilla-central/rev/6b169a883cbf
https://hg.mozilla.org/mozilla-central/rev/732c2765dc44
https://hg.mozilla.org/mozilla-central/rev/012bb0ef8621
https://hg.mozilla.org/mozilla-central/rev/16dda9d15c06