1423102 - cache l10n values in RequestListColumnTransferredSize

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P3)

Description

[[e-mail]]

in bug 1421926 comment 8 I found cache l10n strings also bring 5% perf gain 

complicated.netmonitor.requestsFinished -5.81% (low)
complicated.netmonitor.requestsFinished -4.80% (med)

https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=mozilla-central&newProject=try&newRevision=41173ef9f599deff7d5c1f602d24f8dc20e172c1&originalSignature=edaec66500db21d37602c99daa61ac983f21a6ac&newSignature=edaec66500db21d37602c99daa61ac983f21a6ac&filter=netmonitor&framework=1&selectedTimeRange=172800

We should do this simple cache whether we want Bug 1421926 or not

Comment 1

[[e-mail]]

Attachment: Bug 1423102 - cache l10n values in RequestListColumnTransferredSize;

Review commit: https://reviewboard.mozilla.org/r/205344/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205344/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8934420 [details]
Bug 1423102 - cache l10n values in RequestListColumnTransferredSize;

https://reviewboard.mozilla.org/r/205344/#review210940

As we discussed at the meeting the patch won't have significant impact of perf since `L10N.getStr()` is already doing caching. But, I like the patch since it nicely defines constants (strings) at the top of the file and make the code clearer.

R+ assuming try is green.

Thanks Fred!
Honza

Comment 3

[[e-mail]]

Thanks for review!
try green, land it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7624079d0b2
cache l10n values in RequestListColumnTransferredSize;r=Honza

Comment 5

[Alexandre Poirot [:ochameau]]

I don't know why DAMP push from comment 0 was wrong but I pushed again with a custom base run (with whatever was my current tip):
  https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=2b667a68c6ef4a781b5f04675c96fd0a7e705074&newProject=try&newRevision=2be19e1eddc51c130e256a288404fe78993b5868&originalSignature=edaec66500db21d37602c99daa61ac983f21a6ac&newSignature=edaec66500db21d37602c99daa61ac983f21a6ac&filter=netmonitor&framework=1
And this reports no win, as I would expect.

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f7624079d0b2