1423114 - Remove moz_xposix_memalign and moz_xvalloc

Status: RESOLVED FIXED

(Core :: Memory Allocator, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1423114 - Remove moz_xposix_memalign and moz_xvalloc.

They are both infallible wrappers of posix_memalign and valloc.
There is also moz_xmemalign, which wraps memalign, which is always
available as of bug 1402647.

None of them are actually used, but it's still desirable to at least
have one infallible variant, so keep moz_xmemalign and remove the other
two.

While here, we actually make moz_xmemalign always available, since
memalign is always available.

Review commit: https://reviewboard.mozilla.org/r/205370/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205370/

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 8934436 [details]
Bug 1423114 - Remove moz_xposix_memalign and moz_xvalloc.

https://reviewboard.mozilla.org/r/205370/#review211196

I guess you could make an argument in either direction: for consistency we should have a moz_x version of every allocator function, but for code smallness we should only provide moz_x versions that are necessary. I'm happy to go with the latter.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a4050c7e0fd
Remove moz_xposix_memalign and moz_xvalloc. r=njn

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on memory/mozalloc/mozalloc.cpp

https://hg.mozilla.org/integration/autoland/rev/2470860d3e9a6630dc3e9ee6c4ea84f878927172
https://treeherder.mozilla.org/logviewer.html#?job_id=150001660&repo=autoland

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8934436 [details]
Bug 1423114 - Remove moz_xposix_memalign and moz_xvalloc.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/205370/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ff6e7cbed23
Remove moz_xposix_memalign and moz_xvalloc. r=njn

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/0ff6e7cbed23