Closed Bug 1423304 Opened 7 years ago Closed 6 years ago

regression: Treeherder loading spinner dots are cut off when WebRender is enabled

Categories

(Core :: Graphics: WebRender, defect, P1)

Product:
Core
Component:
Graphics: WebRender
Platform:
Unspecified
All
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 --- fixed

People

(Reporter: cpeterson, Assigned: lsalzman)

References

(Blocks 1 open bug,
URL
)

Details

(Keywords: regression, Whiteboard: [wr-reserve]) 

This is a regression from WebRender bug 1420163.

STR:
1. Enable WebRender (gfx.webrender.enabled, gfx.webrender.blob-images).
2. Load Treeherder: https://treeherder.mozilla.org/#/jobs?repo=autoland
3. Click on a Treeherder "B" job to open the job's detail pane.
4. When the detail pane opens, look for the loading spinner animation.

RESULT:
When WebRender is enabled, the load spinner animation's dots have their edges cut off instead of being circles.

I am testing Nightly 59 on macOS 10.13.1.
Blocks: webrender-site-issues
URL: https://treeherder.mozilla.org/#/jobs...
Has Regression Range: --- → yes
Has STR: --- → yes
OS: Unspecified → All
Summary: Treeherder loading spinner dots are cut off when WebRender is enabled → regression: Treeherder loading spinner dots are cut off when WebRender is enabled
Whiteboard: [wr-mvp] [triage]
This is easier to reproduce if you go to File -> Work Offline in Firefox after step 3, and then click on the "B" from a different pushlog entry.

This is the WR regression range, narrowed down from the try pushes in bug 1420163:

*   a2883d09 Auto merge of #2095 - lsalzman:transformed-alpha, r=lsalzman
|\
| * 45ac4adc rasterization space fix
| * 7ed043dc support glyph transforms with alpha and mono font render modes
|/
* b803a4fc Auto merge of #2094 - lsalzman:font-transform-shadow-fix, r=glennw
* 68852ac2 reftest fix
* f70f7607 ensure that we request glyphs without a transform for text shadows

Lee, both PRs are yours, do you have an idea of what might be going on here?
Flags: needinfo?(lsalzman)
Still investigating. This appears to be a problem with clipping of transformed glyphs in the ps_text_run shader.
Flags: needinfo?(lsalzman)
This is being addressed by WR PR https://github.com/servo/webrender/pull/2188
Assignee: nobody → lsalzman
Depends on: 1423203
Priority: -- → P1
See Also: → https://github.com/servo/webrender/pull/2188
Status: NEW → ASSIGNED
Whiteboard: [wr-mvp] [triage] → [wr-reserve]
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
status-firefox59: affected → fixed
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.