142335 - File | Open dies on directories

Status: RESOLVED DUPLICATE of bug 141833

(SeaMonkey :: UI Design, defect)

Description

[Gili Tzabari]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.0.0+) Gecko/20020502
BuildID:    2002050208



Reproducible: Always
Steps to Reproduce:
1. File | Open
2. Enter directory name (ie: d:\tmp) and press ENTER. 
3. Mozilla will crash.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Michael?  This sounds like something that's yours....

Comment 2

[Mike Kaply [:mkaply]]

over to me. probably related to the new filepicker code.

Comment 3

[Mike Kaply [:mkaply]]

I'm not seeing this.

Does it happen with any directory or your d:\tmp?

There might be a file in your TMP directory with a bad icon.

Does the browser start to display the directory before the crash?

Comment 4

[Gili Tzabari]

Problem is specific to d:\tmp. Only one of the files inside the directory
contains EAs and that only contains the ".TYPE" extended attribute.

Crash info:

05-07-2002  23:28:14  SYS3175  PID 005e  TID 0001  Slot 00ef
D:\MOZILLA\MOZILLA.EXE
c0000005
0d1d2a3b
P1=00000002  P2=00000000  P3=XXXXXXXX  P4=XXXXXXXX  
EAX=00000000  EBX=3354e220  ECX=0cd53888  EDX=3354e220
ESI=00000000  EDI=00000000  
DS=0053  DSACC=f0f3  DSLIM=ffffffff  
ES=0053  ESACC=f0f3  ESLIM=ffffffff  
FS=150b  FSACC=00f3  FSLIM=00000030
GS=0000  GSACC=****  GSLIM=********
CS:EIP=005b:0d1d2a3b  CSACC=f0df  CSLIM=ffffffff
SS:ESP=0053:00130b18  SSACC=f0f3  SSLIM=ffffffff
EBP=00130c9c  FLG=00212206

IMGICON.DLL 0001:00002a3b

Comment 5

[Mike Kaply [:mkaply]]

Cool. I know this one. Fix is going to be in another bug.

*** This bug has been marked as a duplicate of 141833 ***

Comment 6

[Mike Kaply [:mkaply]]

Attachment: Better error checking

Error checking was pretty bad in here.

There were a couple cases where we could end up with bad icon data.

Comment 7

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=12880
repository: comm-central
start_time: 2015-03-11T17:47:50
who: kent[at]caspia[dot]com
machine: b-2008-ix-0067
buildname: TB WINNT 5.2 comm-central build
revision: f04bb162851a

TEST-UNEXPECTED-FAIL | check-sync-dirs.py | build file copies are not in sync
mozmake.exe[1]: *** [check-sync-dirs] Error 1
pymake\..\..\mozmake.exe: *** [check] Error 2

Comment 8

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=12879
repository: comm-central
start_time: 2015-03-11T17:48:07
who: kent[at]caspia[dot]com
machine: b-2008-ix-0006
buildname: TB WINNT 5.2 comm-central leak test build
revision: f04bb162851a

TEST-UNEXPECTED-FAIL | check-sync-dirs.py | build file copies are not in sync
mozmake.exe[1]: *** [check-sync-dirs] Error 1
pymake\..\..\mozmake.exe: *** [check] Error 2

Comment 9

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=12881
repository: comm-central
start_time: 2015-03-11T17:47:50
who: kent[at]caspia[dot]com
machine: bld-lion-r5-006
buildname: TB OS X 10.7 comm-central build
revision: f04bb162851a

TEST-UNEXPECTED-FAIL | check-sync-dirs.py | build file copies are not in sync
make[1]: *** [check-sync-dirs] Error 1
make: *** [check] Error 2