1423356 - Remove _browserIds from GeckoDriver class

Status: RESOLVED INVALID

(Remote Protocol :: Marionette, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

The GeckoDriver#_browserIds property attempts to track the permanentKeys
of content browsers but it does not work.  In preparation for the
window tracking refactoring we should remove it.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1423356 - Remove dead permanentKey tracker from Marionette.

GeckoDriver#_browserIds attempts to track the permanentKey of the
content browser, but it does so wrongly.  The current implementation
does not work because browser.Context#register is not called
consequentially when a browser suffers a remoteness change.

In preparation for a larger window tracking refactoring it is useful
to get rid of possibly confusing and misleading code paths

Review commit: https://reviewboard.mozilla.org/r/205602/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205602/

Comment 2

[Andreas Tolfsen ❲:ato❳]

OK, apparently I was wrong here.  This _is_ being used,
but only for certain things.  I will replace it as part of
https://bugzil.la/marionette-window-tracking instead.