Closed Bug 1423372 Opened 3 years ago Closed 3 years ago

Move MediaDecoder::BackgroundVideoDecodingPermissionObserver into its own file

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

Details

Attachments

(2 files)

Currently GeckoMedia is maintaining a fork of MediaDecoder.cpp, as we can't handle the MediaDecoder::BackgroundVideoDecodingPermissionObserver's usage of Gecko DOM classes such as documents, windows, and AsyncEventDispatcher. So it would be great if we can move BackgroundVideoDecodingPermissionObserver out into its own file, so that GeckoMedia can just maintain an implementation of BackgroundVideoDecodingPermissionObserver which doe nothing, instead of maintaining a fork of MediaDecoder. This should make keeping GeckoMedia's code in sync with Firefox's easier.
Comment on attachment 8934721 [details]
Bug 1423372 - Remove some unnecessary includes and fix unified build problems.

https://reviewboard.mozilla.org/r/205618/#review211266
Attachment #8934721 - Flags: review?(jwwang) → review+
Comment on attachment 8934720 [details]
Bug 1423372 - Move MediaDecoder::BackgroundVideoDecodingPermissionObserver to its own file.

https://reviewboard.mozilla.org/r/205616/#review211268
Attachment #8934720 - Flags: review?(jwwang) → review+
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dfe90994b1ae
Move MediaDecoder::BackgroundVideoDecodingPermissionObserver to its own file. r=jwwang
https://hg.mozilla.org/integration/autoland/rev/1670117c94bc
Remove some unnecessary includes and fix unified build problems. r=jwwang
https://hg.mozilla.org/mozilla-central/rev/dfe90994b1ae
https://hg.mozilla.org/mozilla-central/rev/1670117c94bc
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.