1423381 - 'Schedule a duplication' button is missing on rules page for signoff-controlled channels

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (frontend), enhancement, P1)

Description

[Nick Thomas [:nthomas] (UTC+12)]

jlund noticed that you can't schedule a the duplication of a rule, for channels which are controlled by signoffs and we show 'Schedule an Update' and 'Schedule for Deletion' buttons. A workaround is to copy each field over.

Comment 1

[Vikas Prasad Mahato [:vikas_mahato]]

Hey!
I would like to work on this bug.

Comment 2

[[e-mail] (:bhearsum)]

(In reply to Vikas Prasad Mahato [:vikas_mahato] from comment #1)
> Hey!
> I would like to work on this bug.

It's all yours! Once you have the dev environment up and running (http://mozilla-balrog.readthedocs.io/en/latest/contribute.html#usage) have a look at http://localhost:8080/rules

What this bug wants is for a "Schedule Duplication" button to be added to that UI. It should trigger the "Schedule a New Rule" dialog, but prefill the fields with the information from the Rule it is associated with.

Please let me know if anything is unclear, or you have other questions.

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/balrog/pull/458

Comment 4

[Vikas Prasad Mahato [:vikas_mahato]]

I have sent a pull request. Please review it and let me know if anything needs to be changed.

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/662ddfea9723ff5f75e3c090232679a269068189
bug 1423381: 'Schedule a duplication' button is missing on rules page for signoff-controlled channels (#458). r=bhearsum

Comment 6

[Vikas Prasad Mahato [:vikas_mahato]]

I think we should mark this issue as resolved?

Comment 7

[[e-mail] (:bhearsum)]

(In reply to Vikas Prasad Mahato [:vikas_mahato] from comment #6)
> I think we should mark this issue as resolved?

We usually wait until new code is in production to do that, but we can go ahead here =)

Comment 8

[[e-mail] (:bhearsum)]

This hit production today.