Closed
Bug 1423415
Opened 7 years ago
Closed 7 years ago
[Fx LCM] Activity Stream Snippets Template - email CTA
Categories
(www.mozilla.org :: General, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: erenaud, Assigned: jpetto)
References
(Blocks 1 open bug)
Details
Brief - https://docs.google.com/document/d/1q3nmu-47zFEIMThAKUjZ52KNlswH-bTOKx1evHBEoJQ/edit
Comments from jpetto:
"It appears we can post to bedrock from about:home for the newsletter signup
but there are some other nuances such as: we have to post to a URL with a locale, such as en-US" - (It is unclear how that will work with delivering the snippet).
Assignee | ||
Comment 1•7 years ago
|
||
Pull request has been opened: https://github.com/mozmeao/snippets/pull/130
Reporter | ||
Comment 2•7 years ago
|
||
Giorgos / Aaron - per comments in the commit - https://github.com/mozmeao/snippets/pull/130 - please confer on design parameters and provide final direction here.
Flags: needinfo?(giorgos)
Flags: needinfo?(abenson)
Comment 3•7 years ago
|
||
from my end we only need to update the block button in stage two and we're good to merge. replied in pr
Flags: needinfo?(giorgos)
Comment 4•7 years ago
|
||
Template available in production under the name "[Activity Steam] Newsletter Signup"
Comment 5•7 years ago
|
||
(In reply to Eric Renaud from comment #2)
> Giorgos / Aaron - per comments in the commit -
> https://github.com/mozmeao/snippets/pull/130 - please confer on design
> parameters and provide final direction here.
Those font sizes look good and were designed around the existing font sizes on New Tab (see Pocket/Highlight cards) so the snippet elements felt cohesive.
As an aside, we may readdress font sizes now that we've nailed down guides in the design system (see https://design.firefox.com/photon/visuals/typography.html) but we can worry about that later.
Apologies for the late reply (was out with sick family).
Flags: needinfo?(abenson)
Assignee | ||
Comment 6•7 years ago
|
||
This was merged in pull 130:
https://github.com/mozmeao/snippets/pull/130
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•