Closed Bug 1423465 Opened 3 years ago Closed 3 years ago

Assert MediaCacheStream::GetCachedDataEnd/GetDownloadRate are called off the main thread

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(7 files)

We will run some ChannelMediaDecoder functions off the main thread in order to add the assertions.
Assignee: nobody → jwwang
Blocks: 1369263
Priority: -- → P3
Attachment #8934849 - Flags: review?(bechen)
Attachment #8934850 - Flags: review?(bechen)
Attachment #8934851 - Flags: review?(bechen)
Attachment #8934852 - Flags: review?(bechen)
Attachment #8934853 - Flags: review?(bechen)
Attachment #8934854 - Flags: review?(bechen)
Attachment #8934855 - Flags: review?(bechen)
Comment on attachment 8934849 [details]
Bug 1423465. P1 - expose MDSM::OwnerThread() to the public.

https://reviewboard.mozilla.org/r/205780/#review211316
Attachment #8934849 - Flags: review?(bechen) → review+
Comment on attachment 8934850 [details]
Bug 1423465. P2 - run UpdatePlaybackRate() off the main thread.

https://reviewboard.mozilla.org/r/205782/#review211336
Attachment #8934850 - Flags: review?(bechen) → review+
Comment on attachment 8934851 [details]
Bug 1423465. P3 - assert MediaCacheStream::SetPlaybackRate() is called off the main thread.

https://reviewboard.mozilla.org/r/205784/#review211338
Attachment #8934851 - Flags: review?(bechen) → review+
Comment on attachment 8934852 [details]
Bug 1423465. P4 - run GetStatistics() off the main thread.

https://reviewboard.mozilla.org/r/205786/#review211346
Attachment #8934852 - Flags: review?(bechen) → review+
Comment on attachment 8934853 [details]
Bug 1423465. P5 - run ComputePlaybackRate() off the main thread.

https://reviewboard.mozilla.org/r/205788/#review211352
Attachment #8934853 - Flags: review?(bechen) → review+
Comment on attachment 8934854 [details]
Bug 1423465. P6 - assert some MediaCacheStream functions are run off the main thread.

https://reviewboard.mozilla.org/r/205790/#review211356
Attachment #8934854 - Flags: review?(bechen) → review+
Comment on attachment 8934855 [details]
Bug 1423465. P7 - GetOwner()->DownloadProgressed() should be called after updating mCanPlayThrough.

https://reviewboard.mozilla.org/r/205792/#review211358
Attachment #8934855 - Flags: review?(bechen) → review+
Attachment #8934849 - Flags: review?(gsquelart)
Attachment #8934850 - Flags: review?(gsquelart)
Attachment #8934851 - Flags: review?(gsquelart)
Attachment #8934852 - Flags: review?(gsquelart)
Attachment #8934853 - Flags: review?(gsquelart)
Attachment #8934854 - Flags: review?(gsquelart)
Attachment #8934855 - Flags: review?(gsquelart)
Comment on attachment 8934849 [details]
Bug 1423465. P1 - expose MDSM::OwnerThread() to the public.

https://reviewboard.mozilla.org/r/205780/#review211588
Attachment #8934849 - Flags: review?(gsquelart) → review+
Comment on attachment 8934850 [details]
Bug 1423465. P2 - run UpdatePlaybackRate() off the main thread.

https://reviewboard.mozilla.org/r/205782/#review211590
Attachment #8934850 - Flags: review?(gsquelart) → review+
Comment on attachment 8934851 [details]
Bug 1423465. P3 - assert MediaCacheStream::SetPlaybackRate() is called off the main thread.

https://reviewboard.mozilla.org/r/205784/#review211592
Attachment #8934851 - Flags: review?(gsquelart) → review+
Comment on attachment 8934852 [details]
Bug 1423465. P4 - run GetStatistics() off the main thread.

https://reviewboard.mozilla.org/r/205786/#review211596
Attachment #8934852 - Flags: review?(gsquelart) → review+
Comment on attachment 8934853 [details]
Bug 1423465. P5 - run ComputePlaybackRate() off the main thread.

https://reviewboard.mozilla.org/r/205788/#review211598
Attachment #8934853 - Flags: review?(gsquelart) → review+
Comment on attachment 8934854 [details]
Bug 1423465. P6 - assert some MediaCacheStream functions are run off the main thread.

https://reviewboard.mozilla.org/r/205790/#review211600
Attachment #8934854 - Flags: review?(gsquelart) → review+
Comment on attachment 8934855 [details]
Bug 1423465. P7 - GetOwner()->DownloadProgressed() should be called after updating mCanPlayThrough.

https://reviewboard.mozilla.org/r/205792/#review211602
Attachment #8934855 - Flags: review?(gsquelart) → review+
Thanks for the reviews!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/da6e8e21f061
P1 - expose MDSM::OwnerThread() to the public. r=bechen,gerald
https://hg.mozilla.org/integration/autoland/rev/c4910160b6e3
P2 - run UpdatePlaybackRate() off the main thread. r=bechen,gerald
https://hg.mozilla.org/integration/autoland/rev/1d5dc1fa6172
P3 - assert MediaCacheStream::SetPlaybackRate() is called off the main thread. r=bechen,gerald
https://hg.mozilla.org/integration/autoland/rev/73b7657b4c39
P4 - run GetStatistics() off the main thread. r=bechen,gerald
https://hg.mozilla.org/integration/autoland/rev/a493885e5a0d
P5 - run ComputePlaybackRate() off the main thread. r=bechen,gerald
https://hg.mozilla.org/integration/autoland/rev/5807f7c17c4e
P6 - assert some MediaCacheStream functions are run off the main thread. r=bechen,gerald
https://hg.mozilla.org/integration/autoland/rev/821560cd716d
P7 - GetOwner()->DownloadProgressed() should be called after updating mCanPlayThrough. r=bechen,gerald
Depends on: 1448181
You need to log in before you can comment on or make changes to this bug.