Closed
Bug 1423490
Opened 7 years ago
Closed 6 years ago
Move side effects from SVG attribute setting to BeforeSetAttr / AfterSetAttr, and devirtualize SetAttr
Categories
(Core :: DOM: Core & HTML, enhancement, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: emilio, Assigned: bzbarsky)
References
Details
Attachments
(2 files)
|
4.88 KB,
patch
|
bytesized
:
review+
|
Details | Diff | Splinter Review |
|
6.22 KB,
patch
|
bytesized
:
review+
|
Details | Diff | Splinter Review |
From bug 1423167: > So... The only overrides of this that are subclasses of Element are SVGAElement::SetAttr and SVGStyleElement::SetAttr. It looks like those got skipped in bug 1365092 because of some unrelated SVG problems. Do you mind filing a followup to move the work there into AfterSetAttr and devirtualize this function?
|
||
Updated•7 years ago
|
Priority: -- → P2
|
Assignee | |
Updated•6 years ago
|
Summary: Move side effects from SVG attribute parsing to BeforeSetAttr / AfterSetAttr, and devirtualize SetAttr → Move side effects from SVG attribute setting to BeforeSetAttr / AfterSetAttr, and devirtualize SetAttr
|
|
Assignee | |
Comment 1•6 years ago
|
||
This aligns SVGAElement with HTMLAnchorElement in terms of how they handle attribute changes. MozReview-Commit-ID: Azr6tTBaxTT
Attachment #8938608 -
Flags: review?(ksteuber)
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•6 years ago
|
||
This aligns the behavior with HTMLStyleElement. There are no more overrides, so SetAttr can become non-virtual. MozReview-Commit-ID: 9PFrHg7x0nY
Attachment #8938609 -
Flags: review?(ksteuber)
|
|
Assignee | |
Comment 3•6 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=29f7195cabb3ff810804e87ccf7f8fe5cbcd901d
|
||
Comment 4•6 years ago
|
||
Comment on attachment 8938608 [details] [diff] [review] part 1. Stop overriding SetAttr in SVGAElement Review of attachment 8938608 [details] [diff] [review]: ----------------------------------------------------------------- These both look good to me.
Attachment #8938608 -
Flags: review?(ksteuber) → review+
|
|
||
Updated•6 years ago
|
Attachment #8938609 -
Flags: review?(ksteuber) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1427408aa366 part 1. Stop overriding SetAttr in SVGAElement. r=bytesized https://hg.mozilla.org/integration/mozilla-inbound/rev/3384659645d3 part 2. Stop overriding SetAttr in SVGStyleElement. r=bytesized
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1427408aa366 https://hg.mozilla.org/mozilla-central/rev/3384659645d3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•