Move side effects from SVG attribute setting to BeforeSetAttr / AfterSetAttr, and devirtualize SetAttr

RESOLVED FIXED in Firefox 59

Status

()

P2
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: emilio, Assigned: bzbarsky)

Tracking

unspecified
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(2 attachments)

From bug 1423167:

> So...  The only overrides of this that are subclasses of Element are SVGAElement::SetAttr and SVGStyleElement::SetAttr.  It looks like those got skipped in bug 1365092 because of some unrelated SVG problems.  Do you mind filing a followup to move the work there into AfterSetAttr and devirtualize this function?
(Reporter)

Updated

a year ago
See Also: → bug 1423492
Priority: -- → P2
Summary: Move side effects from SVG attribute parsing to BeforeSetAttr / AfterSetAttr, and devirtualize SetAttr → Move side effects from SVG attribute setting to BeforeSetAttr / AfterSetAttr, and devirtualize SetAttr
Blocks: 1423492
Created attachment 8938608 [details] [diff] [review]
part 1.  Stop overriding SetAttr in SVGAElement

This aligns SVGAElement with HTMLAnchorElement in terms of how they handle
attribute changes.

MozReview-Commit-ID: Azr6tTBaxTT
Attachment #8938608 - Flags: review?(ksteuber)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Created attachment 8938609 [details] [diff] [review]
part 2.  Stop overriding SetAttr in SVGStyleElement

This aligns the behavior with HTMLStyleElement.

There are no more overrides, so SetAttr can become non-virtual.

MozReview-Commit-ID: 9PFrHg7x0nY
Attachment #8938609 - Flags: review?(ksteuber)
Comment on attachment 8938608 [details] [diff] [review]
part 1.  Stop overriding SetAttr in SVGAElement

Review of attachment 8938608 [details] [diff] [review]:
-----------------------------------------------------------------

These both look good to me.
Attachment #8938608 - Flags: review?(ksteuber) → review+
Attachment #8938609 - Flags: review?(ksteuber) → review+

Comment 5

a year ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1427408aa366
part 1.  Stop overriding SetAttr in SVGAElement.  r=bytesized
https://hg.mozilla.org/integration/mozilla-inbound/rev/3384659645d3
part 2.  Stop overriding SetAttr in SVGStyleElement.  r=bytesized

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1427408aa366
https://hg.mozilla.org/mozilla-central/rev/3384659645d3
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.