Closed Bug 1423512 Opened 3 years ago Closed 3 years ago

Don't include mozalloc.h when XPCOM_GLUE is set.

Categories

(Core :: Memory Allocator, enhancement)

Product:
Core
Component:
Memory Allocator
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(2 files)

Bug 1423512 - Remove unnecessary XPCOM_GLUE define in DMD.
59 bytes, text/x-review-board-request
n.nethercote
: review+
Details
Bug 1423512 - Remove infallible allocator exception for xpcom glue code.
59 bytes, text/x-review-board-request
erahm
: review+
Details 
No description provided.
Comment on attachment 8934907 [details]
Bug 1423512 - Remove unnecessary XPCOM_GLUE define in DMD.

https://reviewboard.mozilla.org/r/205836/#review211376
Attachment #8934907 - Flags: review?(n.nethercote) → review+
Comment on attachment 8934908 [details]
Bug 1423512 - Remove infallible allocator exception for xpcom glue code.

https://reviewboard.mozilla.org/r/205838/#review211516

::: config/gcc-stl-wrapper.template.h:49
(Diff revision 1)
>  #include_next <${HEADER}>
>  #pragma GCC visibility pop
>  
>  #ifdef MOZ_INCLUDE_MOZALLOC_H_FROM_${HEADER}
>  // See if we're in code that can use mozalloc.  NB: this duplicates
>  // code in nscore.h because nscore.h pulls in prtypes.h, and chromium

This comment is outdated/confusing. `nscore.h` doesn't include `prtypes.h`. Maybe remove it while you're in here or perhaps we can just include `nscore.h` now?
Attachment #8934908 - Flags: review?(erahm) → review+
Actually, I want to remove that mozalloc.h include from nscore.h, so I'll just remove that NB.
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/1e489f546448
Remove unnecessary XPCOM_GLUE define in DMD. r=njn
https://hg.mozilla.org/integration/autoland/rev/0c9996186048
Remove infallible allocator exception for xpcom glue code. r=erahm
https://hg.mozilla.org/mozilla-central/rev/1e489f546448
https://hg.mozilla.org/mozilla-central/rev/0c9996186048
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.