Closed
Bug 1423524
Opened 7 years ago
Closed 7 years ago
Fix YUVColorSpace of TSurfaceDescriptorDXGIYCbCr at GLBlitHelper::BlitImage()
Categories
(Core :: Graphics, enhancement)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
Details
Attachments
(1 file, 1 obsolete file)
|
1.01 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
Bug 1415763 added YUVColorSpace to SurfaceDescriptorDXGIYCbCr. Then GLBlitHelper::BlitImage() could know correct YUVColorSpace of SurfaceDescriptorDXGIYCbCr.
|
Assignee | |
Comment 1•7 years ago
|
||
Assignee: nobody → sotaro.ikeda.g
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8934922 -
Flags: review?(jgilbert)
|
|
Assignee | |
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=17e20eab60ed0cccdfe588abad4be86e2ee51bc4
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8934922 [details] [diff] [review] patch - Fix YUVColorSpace of TSurfaceDescriptorDXGIYCbCr at GLBlitHelper::BlitImage() Review of attachment 8934922 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/gl/GLBlitHelperD3D.cpp @@ +197,5 @@ > > const auto& clipSize = subdesc.size(); > const auto& ySize = subdesc.sizeY(); > const auto& uvSize = subdesc.sizeCbCr(); > + const auto& yUVColorSpace = subdesc.yUVColorSpace(); Keep the colorSpace name. Not sure who r+'d yUVColorSpace, but it should have been yuvColorSpace.
Attachment #8934922 -
Flags: review?(jgilbert) → review+
|
|
Assignee | |
Comment 4•7 years ago
|
||
Attachment #8934922 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•7 years ago
|
||
Comment on attachment 8935590 [details] [diff] [review] patch - Fix YUVColorSpace of TSurfaceDescriptorDXGIYCbCr at GLBlitHelper::BlitImage() Applied the comment.
Attachment #8935590 -
Flags: review+
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1514dd91f40e Fix YUVColorSpace of TSurfaceDescriptorDXGIYCbCr at GLBlitHelper::BlitImage() r=jgilbert
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1514dd91f40e
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•