1423524 - Fix YUVColorSpace of TSurfaceDescriptorDXGIYCbCr at GLBlitHelper::BlitImage()

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

Bug 1415763 added YUVColorSpace to SurfaceDescriptorDXGIYCbCr. Then GLBlitHelper::BlitImage() could know correct YUVColorSpace of SurfaceDescriptorDXGIYCbCr.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix YUVColorSpace of TSurfaceDescriptorDXGIYCbCr at GLBlitHelper::BlitImage()

Comment 2

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=17e20eab60ed0cccdfe588abad4be86e2ee51bc4

Comment 3

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8934922 [details] [diff] [review]
patch - Fix YUVColorSpace of TSurfaceDescriptorDXGIYCbCr at GLBlitHelper::BlitImage()

Review of attachment 8934922 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLBlitHelperD3D.cpp
@@ +197,5 @@
>  
>              const auto& clipSize = subdesc.size();
>              const auto& ySize = subdesc.sizeY();
>              const auto& uvSize = subdesc.sizeCbCr();
> +            const auto& yUVColorSpace = subdesc.yUVColorSpace();

Keep the colorSpace name. Not sure who r+'d yUVColorSpace, but it should have been yuvColorSpace.

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix YUVColorSpace of TSurfaceDescriptorDXGIYCbCr at GLBlitHelper::BlitImage()

Comment 5

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8935590 [details] [diff] [review]
patch - Fix YUVColorSpace of TSurfaceDescriptorDXGIYCbCr at GLBlitHelper::BlitImage()

Applied the comment.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1514dd91f40e
Fix YUVColorSpace of TSurfaceDescriptorDXGIYCbCr at GLBlitHelper::BlitImage() r=jgilbert

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1514dd91f40e