Fix YUVColorSpace of TSurfaceDescriptorDXGIYCbCr at GLBlitHelper::BlitImage()

RESOLVED FIXED in Firefox 59

Status

()

Core
Graphics
RESOLVED FIXED
2 months ago
a month ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

unspecified
mozilla59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 months ago
Bug 1415763 added YUVColorSpace to SurfaceDescriptorDXGIYCbCr. Then GLBlitHelper::BlitImage() could know correct YUVColorSpace of SurfaceDescriptorDXGIYCbCr.
(Assignee)

Comment 1

2 months ago
Created attachment 8934922 [details] [diff] [review]
patch - Fix YUVColorSpace of TSurfaceDescriptorDXGIYCbCr at GLBlitHelper::BlitImage()
Assignee: nobody → sotaro.ikeda.g
(Assignee)

Updated

2 months ago
Attachment #8934922 - Flags: review?(jgilbert)
Comment on attachment 8934922 [details] [diff] [review]
patch - Fix YUVColorSpace of TSurfaceDescriptorDXGIYCbCr at GLBlitHelper::BlitImage()

Review of attachment 8934922 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLBlitHelperD3D.cpp
@@ +197,5 @@
>  
>              const auto& clipSize = subdesc.size();
>              const auto& ySize = subdesc.sizeY();
>              const auto& uvSize = subdesc.sizeCbCr();
> +            const auto& yUVColorSpace = subdesc.yUVColorSpace();

Keep the colorSpace name. Not sure who r+'d yUVColorSpace, but it should have been yuvColorSpace.
Attachment #8934922 - Flags: review?(jgilbert) → review+
(Assignee)

Comment 4

2 months ago
Created attachment 8935590 [details] [diff] [review]
patch - Fix YUVColorSpace of TSurfaceDescriptorDXGIYCbCr at GLBlitHelper::BlitImage()
Attachment #8934922 - Attachment is obsolete: true
(Assignee)

Comment 5

2 months ago
Comment on attachment 8935590 [details] [diff] [review]
patch - Fix YUVColorSpace of TSurfaceDescriptorDXGIYCbCr at GLBlitHelper::BlitImage()

Applied the comment.
Attachment #8935590 - Flags: review+

Comment 6

2 months ago
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1514dd91f40e
Fix YUVColorSpace of TSurfaceDescriptorDXGIYCbCr at GLBlitHelper::BlitImage() r=jgilbert

Comment 7

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1514dd91f40e
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.