1423549 - PerformanceSignature specifies unique_together twice, so the first is ignored

Status: RESOLVED FIXED

(Tree Management :: Perfherder, enhancement, P1)

Description

[Ed Morley [:emorley]]

I noticed that PerformanceSignature has:

    class Meta:
        db_table = 'performance_signature'
        # make sure there is only one signature per repository with a
        # particular set of properties
        unique_together = ('repository', 'framework', 'platform',
                           'option_collection', 'suite', 'test',
                           'last_updated', 'extra_options')
        # make sure there is only one signature of any hash per
        # repository (same hash in different repositories is allowed)
        unique_together = ('repository', 'framework', 'signature_hash')

(https://github.com/mozilla/treeherder/blob/149830984bc4e42cd6f39cde5d2c529c32813e07/treeherder/perf/models.py#L84-L91)

ie: the value for `unique_together` is overwritten, meaning there are fewer constraints (and indexes) actually set than meets the eye.

Will, do you know what should be defined here?

Comment 1

[William Lachance (:wlach)]

Oops. I think I meant to define two unique together constraints. I think as long as we have signature hashes, we need both. Converting this to one unique_together (a tuple of tuples) should do the trick. Would you mind terribly doing this? I don't have a full treeherder environment set up at the moment.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3979

Comment 3

[William Lachance (:wlach)]

Comment on attachment 9006196 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3979

Thanks Ionut!

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/e307fad711304bff66872352883214c254796214
Bug 1423549 - Fix PerformanceSignature uniqueness (#3979)