Closed Bug 1423580 Opened 6 years ago Closed 6 years ago

[Stylo-chrome] "Show Downloads" font in Library on Nighlty 59 doesn't look the same as on Firefox 57

Categories

(Core :: CSS Parsing and Computation, defect)

59 Branch
defect
Not set
normal

Tracking

()

RESOLVED INVALID
Tracking Status
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 --- affected

People

(Reporter: hyacoub, Unassigned)

References

Details

Attachments

(1 file)

Attached image library.png
[Affected versions]: 
Nightly 59.0a1

[Affected platforms]:
Platforms: Windows 10 x 64

[Preconditions]:
1. Go to about:config
2. "layout.css.servo.enabled" pref's default value is already TRUE
3. Set “layout.css.servo.chrome.enabled” to TRUE
4. Restart Firefox for the "layout.css.servo.chrome.enabled" pref change to take effect

[Steps to reproduce]:
1. Launch Firefox.
2. From toolbar click on "View history, save bookmarks, and more".
3. Click on "Downloads".
4. Click on "Show All Downloads".
5. Compare the results with 

[Expected result]:
"Show Downloads" font should match with Stylo-chrome with Firefox 57's UI.

[Actual result]:
"Show Downloads" font doesn't match comparing with Stylo-chrome with Firefox 57's UI.
(Ftr, instead of comparing with 57, it'd be nice to compare with and without the pref on on the same revision, that'd make this easier to diagnose).
So, I think this is an INVALID bug like the other two bugs, given it's a comparison to Firefox 57 rather than to Firefox 59 without stylo-chrome.

It seems this is also a frontend change, and I see the same thing regardless whether stylo-chrome is enabled.

It may be worth looking for the regression range, though, since there are indeed some frontend changes we made for stylo-chrome (e.g. the removal of <children> matching hack) which should be considered regression. If the regression range ends up with a bug belongs to the Firefox frontend team, it is more likely an intended change from them, then.
Hani, my suggestion to compare Firefox 59 with stylo-chrome to Firefox 57 was a bad idea. I didn't realize how many front-end UI changes, like this font change, were made since Firefox 57. Sorry!

Ovidiu pinged me on Slack and we concluded that we should not use Firefox 57 for comparison. We should just compare Firefox 59 with the "layout.css.servo.chrome.enabled" = true and = false. You will need to restart the browser after changing the pref value.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: