Closed Bug 1423586 Opened 6 years ago Closed 6 years ago

Enhance test case for typed array in operator inline cache

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: mgaudet, Assigned: mgaudet)

Details

Attachments

(1 file)

In Bug 1419372, in comment 13, Simon Lindholm pointed out that the test case associated was likely not testing what it was intended to due to another piece of the specification of TypedArrays. 

This bug is for enhancing the test case to correct that.
Before this patch, the sets would be ignored by 9.4.5.9.
Assignee: nobody → mgaudet
Status: NEW → ASSIGNED
Attachment #8934984 - Flags: review?(tcampbell)
Comment on attachment 8934984 [details] [diff] [review]
Enahance Test case for TypedArray IC

Review of attachment 8934984 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for addressing this :)
Attachment #8934984 - Flags: review?(tcampbell) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/144dfe94c302
Enhance test case for TypedArray IC. r=tcampbell
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/144dfe94c302
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: