Closed
Bug 1423586
Opened 6 years ago
Closed 6 years ago
Enhance test case for typed array in operator inline cache
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: mgaudet, Assigned: mgaudet)
Details
Attachments
(1 file)
1.13 KB,
patch
|
tcampbell
:
review+
|
Details | Diff | Splinter Review |
In Bug 1419372, in comment 13, Simon Lindholm pointed out that the test case associated was likely not testing what it was intended to due to another piece of the specification of TypedArrays. This bug is for enhancing the test case to correct that.
Assignee | ||
Comment 1•6 years ago
|
||
Before this patch, the sets would be ignored by 9.4.5.9.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → mgaudet
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•6 years ago
|
||
Try build for attachment: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d78209e932ed150cc1de50bdb3b7209d464b7cf
Assignee | ||
Updated•6 years ago
|
Attachment #8934984 -
Flags: review?(tcampbell)
Comment 3•6 years ago
|
||
Comment on attachment 8934984 [details] [diff] [review] Enahance Test case for TypedArray IC Review of attachment 8934984 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for addressing this :)
Attachment #8934984 -
Flags: review?(tcampbell) → review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/144dfe94c302 Enhance test case for TypedArray IC. r=tcampbell
Keywords: checkin-needed
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/144dfe94c302
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•