1423647 - Magnifying glass highlight button looks broken in Downloads Library

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P2)

Description

[Mehmet]

Attachment: download_library.mov

macOS 10.12.6
59.0a1 (2017-12-06) (64-Bit)

1.) Open the Download Library
2.) Hover over the Magnifying Glass 

Actual: The hover button looks broken

Expected: A nice polished hover button

A screencast is attached.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1423647 - Restore border-radius for buttons in the Downloads View in the Library.

Review commit: https://reviewboard.mozilla.org/r/206226/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206226/

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8935321 [details]
Bug 1423647 - Restore border-radius for buttons in the Downloads View in the Library.

https://reviewboard.mozilla.org/r/206226/#review211860

Ah, looks like Paolo pointed this out in https://bugzilla.mozilla.org/show_bug.cgi?id=1351998#c7

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b381ddb9779
Restore border-radius for buttons in the Downloads View in the Library. r=mak

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1b381ddb9779

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8935321 [details]
Bug 1423647 - Restore border-radius for buttons in the Downloads View in the Library.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1351998
[User impact if declined]: see comment 0
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial fix
[String changes made/needed]: /

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 8935321 [details]
Bug 1423647 - Restore border-radius for buttons in the Downloads View in the Library.

css fix for downloads view, beta58+

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/366eae257e7e

Comment 8

[Mehmet]

Attachment: handle_close_to_border.png

Thank you for fixing it. I noticed that the bottom part of the handle is very close to the hover button border (please see the attached screenshot). I think this is marginal and hardly noticeable. But if you want I can open a follow up report. Just let me know it. Thanks.

Comment 9

[Dão Gottwald [:dao]]

(In reply to Mehmet from comment #8)
> Created attachment 8935997 [details]
> handle_close_to_border.png
> 
> Thank you for fixing it. I noticed that the bottom part of the handle is
> very close to the hover button border (please see the attached screenshot).
> I think this is marginal and hardly noticeable. But if you want I can open a
> follow up report. Just let me know it. Thanks.

I think we can leave this as is. Thanks.

Comment 10

[Mehmet]

(In reply to Dão Gottwald [::dao] from comment #9)
> I think we can leave this as is. Thanks.

Okay, thank you for your feedback.