Magnifying glass highlight button looks broken in Downloads Library

RESOLVED FIXED in Firefox 58

Status

()

defect
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mehmet.sahin, Assigned: dao)

Tracking

({regression})

Trunk
Firefox 59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox57 wontfix, firefox58 fixed, firefox59 fixed)

Details

Attachments

(3 attachments)

Posted video download_library.mov
macOS 10.12.6
59.0a1 (2017-12-06) (64-Bit)

1.) Open the Download Library
2.) Hover over the Magnifying Glass 

Actual: The hover button looks broken

Expected: A nice polished hover button

A screencast is attached.
Component: Untriaged → Theme
Assignee: nobody → dao+bmo
Blocks: 1351998
Status: NEW → ASSIGNED
Keywords: regression
Priority: -- → P2
Comment on attachment 8935321 [details]
Bug 1423647 - Restore border-radius for buttons in the Downloads View in the Library.

https://reviewboard.mozilla.org/r/206226/#review211860

Ah, looks like Paolo pointed this out in https://bugzilla.mozilla.org/show_bug.cgi?id=1351998#c7
Attachment #8935321 - Flags: review?(mak77) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1b381ddb9779
Restore border-radius for buttons in the Downloads View in the Library. r=mak
https://hg.mozilla.org/mozilla-central/rev/1b381ddb9779
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Comment on attachment 8935321 [details]
Bug 1423647 - Restore border-radius for buttons in the Downloads View in the Library.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1351998
[User impact if declined]: see comment 0
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial fix
[String changes made/needed]: /
Attachment #8935321 - Flags: approval-mozilla-beta?
Comment on attachment 8935321 [details]
Bug 1423647 - Restore border-radius for buttons in the Downloads View in the Library.

css fix for downloads view, beta58+
Attachment #8935321 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Thank you for fixing it. I noticed that the bottom part of the handle is very close to the hover button border (please see the attached screenshot). I think this is marginal and hardly noticeable. But if you want I can open a follow up report. Just let me know it. Thanks.
Flags: needinfo?(dao+bmo)
QA Whiteboard: [good first verify]
(In reply to Mehmet from comment #8)
> Created attachment 8935997 [details]
> handle_close_to_border.png
> 
> Thank you for fixing it. I noticed that the bottom part of the handle is
> very close to the hover button border (please see the attached screenshot).
> I think this is marginal and hardly noticeable. But if you want I can open a
> follow up report. Just let me know it. Thanks.

I think we can leave this as is. Thanks.
Flags: needinfo?(dao+bmo)
(In reply to Dão Gottwald [::dao] from comment #9)
> I think we can leave this as is. Thanks.

Okay, thank you for your feedback.
You need to log in before you can comment on or make changes to this bug.