[KARMA] Karma.bm spams the user when you ask for a 'rank'

VERIFIED FIXED in 2.8

Status

Webtools
Mozbot
P2
major
VERIFIED FIXED
16 years ago
9 years ago

People

(Reporter: Charlie Allom, Assigned: wolf)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

16 years ago
mozbot will /msg spam anyone who asks for a 'rank' with _every_ object and it's karma rank.

this is a waste, unless you are extremely bored. It should be removed and be able to be called with an argument:

<yeled> mozbot, rank
<mozbot> The person with the most karma is foo with 126 points.

<yeled> mozbot, rank all
<mozbot> The person with the most karma is foo with 126 points.
*then precedes to /msg the whole hash!*

or be able to be commented out with a 'vars'
Yeah, I agree.
Summary: Karma.bm spams the user when you ask for a 'rank' → [KARMA] Karma.bm spams the user when you ask for a 'rank'
QA Contact: kerz → mozbot
(Assignee)

Comment 2

10 years ago
Resetting to new default owner.
Assignee: ian → nobody
(Assignee)

Updated

9 years ago
Assignee: nobody → bugtrap
Severity: normal → major
OS: NetBSD → All
Priority: -- → P2
Hardware: PowerPC → All
Target Milestone: --- → 2.8
Version: 2.4 → Trunk

Comment 3

9 years ago
Created attachment 379001 [details] [diff] [review]
Add a limit to which rankings will stopped when reached
(Assignee)

Comment 4

9 years ago
Comment on attachment 379001 [details] [diff] [review]
Add a limit to which rankings will stopped when reached

>-        $self->directSay($event, "Global rankings:");
>+        $self->directSay($event, "Global rankings (top $self->{'ranklimit'}):");
s/top/Top/
>+        $self->directSay($event, "To stop PM 'shutup' to me");
If somebody sets the limit higher than 10, then they can deal. There's other modules that output 10 lines without warning, so this msg should go..

Looks OK otherwise, will r+ an updated patch.
Attachment #379001 - Flags: review-

Comment 5

9 years ago
Created attachment 379006 [details] [diff] [review]
Changes according to comment #4
Attachment #379001 - Attachment is obsolete: true
(Assignee)

Comment 6

9 years ago
Comment on attachment 379006 [details] [diff] [review]
Changes according to comment #4

r=Wolf

Note to self, bump trunk mozbot version to 2.7 before landing.

Will land tonight.
Attachment #379006 - Flags: review+
(Assignee)

Comment 7

9 years ago
Checking in BotModules/Karma.bm;
/cvsroot/mozilla/webtools/mozbot/BotModules/Karma.bm,v  <--  Karma.bm
new revision: 1.10; previous revision: 1.9
done
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Verified Fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.