142376 - [KARMA] Karma.bm spams the user when you ask for a 'rank'

Status: VERIFIED FIXED

(Webtools Graveyard :: Mozbot, defect, P2)

Description

[Charlie Allom]

mozbot will /msg spam anyone who asks for a 'rank' with _every_ object and it's karma rank.

this is a waste, unless you are extremely bored. It should be removed and be able to be called with an argument:

<yeled> mozbot, rank
<mozbot> The person with the most karma is foo with 126 points.

<yeled> mozbot, rank all
<mozbot> The person with the most karma is foo with 126 points.
*then precedes to /msg the whole hash!*

or be able to be commented out with a 'vars'

Comment 1

[Hixie (not reading bugmail)]

Yeah, I agree.

Comment 2

[Wolf [:wolf]]

Resetting to new default owner.

Comment 3

[Jesper Hansen]

Attachment: Add a limit to which rankings will stopped when reached

Comment 4

[Wolf [:wolf]]

Comment on attachment 379001 [details] [diff] [review]
Add a limit to which rankings will stopped when reached

>-        $self->directSay($event, "Global rankings:");
>+        $self->directSay($event, "Global rankings (top $self->{'ranklimit'}):");
s/top/Top/
>+        $self->directSay($event, "To stop PM 'shutup' to me");
If somebody sets the limit higher than 10, then they can deal. There's other modules that output 10 lines without warning, so this msg should go..

Looks OK otherwise, will r+ an updated patch.

Comment 5

[Jesper Hansen]

Attachment: Changes according to comment #4

Comment 6

[Wolf [:wolf]]

Comment on attachment 379006 [details] [diff] [review]
Changes according to comment #4

r=Wolf

Note to self, bump trunk mozbot version to 2.7 before landing.

Will land tonight.

Comment 7

[Wolf [:wolf]]

Checking in BotModules/Karma.bm;
/cvsroot/mozilla/webtools/mozbot/BotModules/Karma.bm,v  <--  Karma.bm
new revision: 1.10; previous revision: 1.9
done

Comment 8

[Tanner M. Young [:tmyoung]]

Verified Fixed.