Closed Bug 1423761 Opened 2 years ago Closed 2 years ago

Make CorrectStyleParentFrame / UpdateStyleOfChildAnonBox deal with abs.pos. anon boxes

Categories

(Core :: Layout, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: mats, Assigned: mats)

References

Details

Attachments

(1 file)

We don't have any of those so far, but bug 1421229 will add one.
Attachment #8935168 - Flags: review?(dholbert)
Comment on attachment 8935168 [details] [diff] [review]
Make CorrectStyleParentFrame / UpdateStyleOfChildAnonBox deal with abs.pos. anon boxes

Review of attachment 8935168 [details] [diff] [review]:
-----------------------------------------------------------------

Could you include a comment (either in the extended commit message, or as a code-comment alongside the two affected lines) to indicate *why* GetInFlowParent() is the right/better way to walk up the frame tree here?

e.g. "For an OOF frame, the parent frame that's associated with our parent style context is the *placeholder's* parent -- not the OOF frame's parent." (I'm assuming that's the reason, at least.)
Attachment #8935168 - Flags: review?(dholbert) → review+
Priority: -- → P1
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1762939d90bb
Make CorrectStyleParentFrame / UpdateStyleOfChildAnonBox deal with abs.pos. anon boxes.  r=dholbert
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/1762939d90bb
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.