Rename toolbar_vertical_separator to toolbar_field_separator

RESOLVED FIXED in Firefox 59

Status

defect
P5
normal
RESOLVED FIXED
a year ago
10 months ago

People

(Reporter: ntim, Assigned: ntim)

Tracking

({dev-doc-complete})

unspecified
mozilla60
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox58 wontfix, firefox59- fixed, firefox60- fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
toolbar_field_separator is more consistent because the color applies to the urlbar (which uses the toolbar_field prefix) separators

Updated

a year ago
Priority: -- → P5
(Assignee)

Updated

a year ago
Assignee: nobody → ntim.bugs
I don't think we need to track this, but if you land the fix and then want to request uplift to beta 59, please do.

Comment 3

a year ago
mozreview-review
Comment on attachment 8947667 [details]
Bug 1423762 - Add support for toolbar_field_separator and proper support for toolbar_vertical_separator.

https://reviewboard.mozilla.org/r/217392/#review223368
Attachment #8947667 - Flags: review?(jaws) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 1309a2c2656999d1ad2680a6dfb48789c4b3b734 -d 595f9b99413b: rebasing 445546:1309a2c26569 "Bug 1423762 - Add support for toolbar_field_separator and proper support for toolbar_vertical_separator. r=jaws" (tip)
merging toolkit/components/extensions/ext-theme.js
merging toolkit/modules/LightweightThemeConsumer.jsm
warning: conflicts while merging toolkit/modules/LightweightThemeConsumer.jsm! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request)

Comment 6

a year ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6710b70f3c83
Add support for toolbar_field_separator and proper support for toolbar_vertical_separator. r=jaws
(Assignee)

Comment 7

a year ago
Comment on attachment 8947667 [details]
Bug 1423762 - Add support for toolbar_field_separator and proper support for toolbar_vertical_separator.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1347190
[User impact if declined]: no user impact, but API introduced would be incorrect for 2 releases as opposed to just one.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: not yet, only manual testing
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none, will attach a special patch for beta
[Is the change risky?]: low
[Why is the change risky/not risky?]: straightforward API change
Attachment #8947667 - Flags: approval-mozilla-beta?
(Assignee)

Updated

a year ago
Blocks: 1347190

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6710b70f3c83
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
(Assignee)

Updated

a year ago
Keywords: dev-doc-needed
Comment on attachment 8947667 [details]
Bug 1423762 - Add support for toolbar_field_separator and proper support for toolbar_vertical_separator.

Keeping some UI elements consistent sounds good, and this looks low-risk. 
Let's uplift for beta 9.
Attachment #8947667 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Updated

10 months ago
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.