1423773 - Remove nsStringGlue.h

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Eric Rahm [:erahm]]

We can replace all usage of nsStringGlue.h, it just forwards to nsString.h (and nsReadableUtils.h, but nsString.h includes that already).

Comment 1

[Eric Rahm [:erahm]]

Attachment: Part 1: Remove usage of nsStringGlue.h

This removes an unnecessary level of indirection by replacing all
nsStringGlue.h instances with just nsString.h.

Comment 2

[Eric Rahm [:erahm]]

Attachment: Part 2: Remove nsStringGlue.h

nsStringGlue.h is no longer used, we can remove it.

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8935179 [details] [diff] [review]
Part 1: Remove usage of nsStringGlue.h

Review of attachment 8935179 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/src/nsRegion.h
@@ +18,4 @@
>  #include "nsRect.h"                     // for mozilla::gfx::IntRect, nsRect
>  #include "nsMargin.h"                   // for nsIntMargin
>  #include "nsRegionFwd.h"                // for nsIntRegion
> +#include "nsString.h"               // for nsCString

indentation

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8935180 [details] [diff] [review]
Part 2: Remove nsStringGlue.h

Review of attachment 8935180 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f6ef04a022f3
Part 1: Remove usage of nsStringGlue.h. r=glandium
https://hg.mozilla.org/integration/mozilla-inbound/rev/3704173ce1cb
Part 2: Remove nsStringGlue.h. r=glandium

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f6ef04a022f3
https://hg.mozilla.org/mozilla-central/rev/3704173ce1cb