Closed
Bug 1423773
Opened 6 years ago
Closed 6 years ago
Remove nsStringGlue.h
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
Details
Attachments
(2 files)
|
20.11 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
|
1.69 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
We can replace all usage of nsStringGlue.h, it just forwards to nsString.h (and nsReadableUtils.h, but nsString.h includes that already).
|
Assignee | |
Comment 1•6 years ago
|
||
This removes an unnecessary level of indirection by replacing all nsStringGlue.h instances with just nsString.h.
Attachment #8935179 -
Flags: review?(mh+mozilla)
|
|
Assignee | |
Comment 2•6 years ago
|
||
nsStringGlue.h is no longer used, we can remove it.
Attachment #8935180 -
Flags: review?(mh+mozilla)
|
|
Assignee | |
Updated•6 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8935179 [details] [diff] [review] Part 1: Remove usage of nsStringGlue.h Review of attachment 8935179 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/src/nsRegion.h @@ +18,4 @@ > #include "nsRect.h" // for mozilla::gfx::IntRect, nsRect > #include "nsMargin.h" // for nsIntMargin > #include "nsRegionFwd.h" // for nsIntRegion > +#include "nsString.h" // for nsCString indentation
Attachment #8935179 -
Flags: review?(mh+mozilla) → review+
|
|
||
Comment 4•6 years ago
|
||
Comment on attachment 8935180 [details] [diff] [review] Part 2: Remove nsStringGlue.h Review of attachment 8935180 [details] [diff] [review]: ----------------------------------------------------------------- \o/
Attachment #8935180 -
Flags: review?(mh+mozilla) → review+
Pushed by erahm@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f6ef04a022f3 Part 1: Remove usage of nsStringGlue.h. r=glandium https://hg.mozilla.org/integration/mozilla-inbound/rev/3704173ce1cb Part 2: Remove nsStringGlue.h. r=glandium
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f6ef04a022f3 https://hg.mozilla.org/mozilla-central/rev/3704173ce1cb
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
||
Updated•3 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•