Closed Bug 1423773 Opened 3 years ago Closed 3 years ago

Remove nsStringGlue.h

Categories

(Core :: String, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: erahm, Assigned: erahm)

Details

Attachments

(2 files)

We can replace all usage of nsStringGlue.h, it just forwards to nsString.h (and nsReadableUtils.h, but nsString.h includes that already).
This removes an unnecessary level of indirection by replacing all
nsStringGlue.h instances with just nsString.h.
Attachment #8935179 - Flags: review?(mh+mozilla)
nsStringGlue.h is no longer used, we can remove it.
Attachment #8935180 - Flags: review?(mh+mozilla)
Status: NEW → ASSIGNED
Comment on attachment 8935179 [details] [diff] [review]
Part 1: Remove usage of nsStringGlue.h

Review of attachment 8935179 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/src/nsRegion.h
@@ +18,4 @@
>  #include "nsRect.h"                     // for mozilla::gfx::IntRect, nsRect
>  #include "nsMargin.h"                   // for nsIntMargin
>  #include "nsRegionFwd.h"                // for nsIntRegion
> +#include "nsString.h"               // for nsCString

indentation
Attachment #8935179 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8935180 [details] [diff] [review]
Part 2: Remove nsStringGlue.h

Review of attachment 8935180 [details] [diff] [review]:
-----------------------------------------------------------------

\o/
Attachment #8935180 - Flags: review?(mh+mozilla) → review+
Pushed by erahm@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f6ef04a022f3
Part 1: Remove usage of nsStringGlue.h. r=glandium
https://hg.mozilla.org/integration/mozilla-inbound/rev/3704173ce1cb
Part 2: Remove nsStringGlue.h. r=glandium
https://hg.mozilla.org/mozilla-central/rev/f6ef04a022f3
https://hg.mozilla.org/mozilla-central/rev/3704173ce1cb
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.