Closed Bug 1423798 Opened 2 years ago Closed 2 years ago
Remove headers included for backwards compatibility in ns
There are a few headers included in `nsString.h` that are there for "backwards compatibility". We should remove these and just include them where necessary.
Work in progress, testing on non-linux platforms
Remove the headers included for "backwards compatibility" and just include them where required.
Attachment #8935489 - Flags: review?(n.nethercote)
Attachment #8935231 - Attachment is obsolete: true
Comment on attachment 8935489 [details] [diff] [review] Remove headers included for backwards compat in nsString.h Review of attachment 8935489 [details] [diff] [review]: ----------------------------------------------------------------- I'm surprised nsMemory.h is so popular. If you haven't already, *please* do a try push before landing...
Attachment #8935489 - Flags: review?(n.nethercote) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/e2beba7e6875 Remove headers included for backwards compat in nsString.h. r=njn
Backed out for failing Browser Chrome tests on Windows 7 debug browser_temporary_permissions_expiry.js Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/a3e5ab878fd44c72f27d53a7058608535de87205 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=e2beba7e6875120ebbbcadf24bcbcb5b86411a94 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=150929862&repo=mozilla-inbound&lineNumber=4084 INFO - Buffered messages finished 4084 23:08:56 ERROR - 138 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/permissions/browser_temporary_permissions_expiry.js | A promise chain failed to handle a rejection: The request is not allowed by the user agent or the platform in the current context. - stack: denyGUMRequest@resource:///modules/ContentWebRTC.jsm:239:3 4085 23:08:56 INFO - receiveMessage@resource:///modules/ContentWebRTC.jsm:81:9 4086 23:08:56 INFO - ContentWebRTCShim@chrome://browser/content/content.js:686:36 4087 23:08:56 INFO - Rejection date: Fri Dec 08 2017 23:08:56 GMT+0000 (Coordinated Universal Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 253
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/630a91d55d86 Remove headers included for backwards compat in nsString.h. r=njn on a CLOSED TREE
Looks like the relanded successfully.
You need to log in before you can comment on or make changes to this bug.