Closed Bug 1423803 Opened 2 years ago Closed 2 years ago

Turn mozilla::fallible into an alias for std::nothrow

Categories

(Core :: Memory Allocator, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

We have fallible operator new with the std::nothrow variant, which is used in third party code. The duplication with our own fallible operator new is unfortunate, and we can reduce the duplication by making one an alias of the other.
Comment on attachment 8935228 [details]
Bug 1423803 - Turn mozilla::fallible into an alias for std::nothrow.

https://reviewboard.mozilla.org/r/206106/#review211646
Attachment #8935228 - Flags: review?(n.nethercote) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/5d4d649431f4
Turn mozilla::fallible into an alias for std::nothrow. r=njn
FYI One of the build metrics alerts flags a big regression:

== Change summary for alert #10910 (as of Thu, 07 Dec 2017 02:49:39 GMT) ==

Regressions:

296%  compiler_metrics num_static_constructors linux64-noopt debug      241.00 -> 955.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=10910
Flags: needinfo?(mh+mozilla)
Depends on: 1424116
https://hg.mozilla.org/mozilla-central/rev/5d4d649431f4
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Flags: needinfo?(mh+mozilla)
You need to log in before you can comment on or make changes to this bug.