1423803 - Turn mozilla::fallible into an alias for std::nothrow

Status: RESOLVED FIXED

(Core :: Memory Allocator, enhancement)

Description

[Mike Hommey [:glandium]]

We have fallible operator new with the std::nothrow variant, which is used in third party code. The duplication with our own fallible operator new is unfortunate, and we can reduce the duplication by making one an alias of the other.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1423803 - Turn mozilla::fallible into an alias for std::nothrow.

The std::nothrow variant of operator new is effectively a fallible
operator new. It is used in third party code.

The duplication with our own fallible operator new is unfortunate, and
we can reduce it by making one an alias of the other.

We keep the fallible library as a dummy on Android because bug 1423802
induces some linking problems.

Review commit: https://reviewboard.mozilla.org/r/206106/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206106/

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 8935228 [details]
Bug 1423803 - Turn mozilla::fallible into an alias for std::nothrow.

https://reviewboard.mozilla.org/r/206106/#review211646

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d4d649431f4
Turn mozilla::fallible into an alias for std::nothrow. r=njn

Comment 4

[Ionuț Goldan [:igoldan]]

FYI One of the build metrics alerts flags a big regression:

== Change summary for alert #10910 (as of Thu, 07 Dec 2017 02:49:39 GMT) ==

Regressions:

296%  compiler_metrics num_static_constructors linux64-noopt debug      241.00 -> 955.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=10910

Comment 5

[Mike Hommey [:glandium]]

Filed bug 1424116.

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5d4d649431f4