Closed Bug 1423809 Opened 2 years ago Closed 2 years ago

Support localized generated files in the Tup backend

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: chmanchester, Assigned: mshal)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

They're currently processed as generated files, but fail due to missing the locale-specific arguments provided by the backend.
Oh, bummer! I expected `LOCALIZED_FILES` to work without extra handling, but I didn't think through `LOCALIZED_GENERATED_FILES` that well. If there's anything we can uplift into the emitter or whatever to make this easier that'd be fine!
Comment on attachment 8935889 [details]
Bug 1423809 - Support localized generated files in the tup backend;

https://reviewboard.mozilla.org/r/206754/#review212566

::: python/mozbuild/mozbuild/backend/tup.py:334
(Diff revision 1)
>              'toolkit/library', # libxul.so
>          )
>          if obj.script and obj.method and obj.relobjdir not in skip_directories:
>              backend_file.export_shell()
>              cmd = self._py_action('file_generate')
> +            if obj.localized:

Consider filing follow-up to track fixing this.  Blocking "Tup, full support" meta ticket or whatever.
Attachment #8935889 - Flags: review+
Attachment #8935889 - Flags: review?(core-build-config-reviews)
Attachment #8935890 - Flags: review?(core-build-config-reviews)
Assignee: nobody → mshal
Comment on attachment 8935889 [details]
Bug 1423809 - Support localized generated files in the tup backend;

https://reviewboard.mozilla.org/r/206754/#review212984

::: python/mozbuild/mozbuild/backend/tup.py:334
(Diff revision 1)
>              'toolkit/library', # libxul.so
>          )
>          if obj.script and obj.method and obj.relobjdir not in skip_directories:
>              backend_file.export_shell()
>              cmd = self._py_action('file_generate')
> +            if obj.localized:

Filed bug 1424896
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s d450ca431b2c -d fba9ddd36edd: rebasing 438980:d450ca431b2c "Bug 1423809 - Support localized generated files in the tup backend; r=nalexander"
merging python/mozbuild/mozbuild/backend/tup.py
rebasing 438981:23f0d611667d "Bug 1423809 - Fixup dist/bin/Tupfile generation; r=nalexander" (tip)
merging python/mozbuild/mozbuild/backend/tup.py
warning: conflicts while merging python/mozbuild/mozbuild/backend/tup.py! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8fc2ba9a2dcb
Support localized generated files in the tup backend; r=nalexander
https://hg.mozilla.org/integration/autoland/rev/22c25f65c0b8
Fixup dist/bin/Tupfile generation; r=nalexander
https://hg.mozilla.org/mozilla-central/rev/8fc2ba9a2dcb
https://hg.mozilla.org/mozilla-central/rev/22c25f65c0b8
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.