1423819 - Assertion failure: pthread_mutex_destroy(&mMutex) == 0 (pthread_mutex_destroy failed), at /builds/worker/workspace/build/src/xpcom/threads/RecursiveMutex.cpp:63

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P2)

Description

[JW Wang [:jwwang] [:jw_wang]]

https://treeherder.mozilla.org/logviewer.html#?job_id=150106033&repo=try&lineNumber=52272

https://searchfox.org/mozilla-central/rev/f5f1c3f294f89cfd242c3af9eb2c40d19d5e04e7/dom/media/webrtc/MediaEngineRemoteVideoSource.cpp#182

Data race in accessing mImageContainer?

Comment 1

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

Attachment: Bug 1423819 - reuse ImageContainer object instead of releasing and creating another one.

Review commit: https://reviewboard.mozilla.org/r/206598/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206598/

Comment 2

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8935692 [details]
Bug 1423819 - reuse ImageContainer object instead of releasing and creating another one.

https://reviewboard.mozilla.org/r/206598/#review212274

I guess this happens on a second Start()? Looks sane.

Comment 3

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

(In reply to Andreas Pehrson [:pehrsons] from comment #2)
> Comment on attachment 8935692 [details]
> Bug 1423819 - reuse ImageContainer object instead of releasing and creating
> another one.
> 
> https://reviewboard.mozilla.org/r/206598/#review212274
> 
> I guess this happens on a second Start()? Looks sane.
Yes.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ae730185fa3
reuse ImageContainer object instead of releasing and creating another one. r=pehrsons

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/6ae730185fa3

Comment 6

[Intermittent Failures Robot]

1 failures in 889 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 1

Platform breakdown:
* linux64-qr: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1423819&startday=2017-12-04&endday=2017-12-10&tree=all