1423856 - You can't open the application "FirefoxNightly.app" because it may be damaged or incomplete.

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[vmoutoussamy]

Attachment: Graphical-error.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171112125346

Steps to reproduce:

Hit the update button this morning to update FirefoxNightly. Then since it didn't restart automatically, I tried to launch it manually and hit this error message:


Actual results:

You can't open the application "FirefoxNightly.app" because it may be damaged or incomplete.


Expected results:

FirefoxNightly start...

Comment 1

[vmoutoussamy]

Attachment: Content of /Applications/FirefoxNightly.app/Contents/MacOS/

/Applications/FirefoxNightly.app/Contents/MacOS/ seems empty... firefox-bin should have been present but it's not.

Comment 2

[vmoutoussamy]

Please let me know what log files or details you need to investigate this issue.

Comment 3

[Justin Dolske [:Dolske]]

I just hit this too. It had been a little while (~week?) since I had last restarted, so I restarted once to apply the (old) staged update, then immediately checked for updates and restarted a second time. I wasn't watching exactly what happened, but came back a minute later and was wondering why Nightly wasn't open. Tried to launch it again and got the same error as attachment 8935308 [details].

The contents of /Applications/FirefoxNightly.app are almost completely missing. Looks like the directory structure is still there, but the only files are a few "CodeResources", channel-prefs.js, and update-settings.ini.

Will attach some relevant files / logs next.

Comment 4

[Justin Dolske [:Dolske]]

Attachment: tarball of broken /Apps/FirefoxNightly.app

Comment 5

[Justin Dolske [:Dolske]]

This is a tarball of ~/Library/Caches/Mozilla/updates/Applications/FirefoxNightly/ (too big to attach, alas).

http://dolske.net/mozilla/tmp/last-staged.tgz

Curiously, I have about 200MB(!) of other stuff under .../updates/, but this is the most recent dir that matches the timestamp of when I was updating Firefox.

Comment 6

[Justin Dolske [:Dolske]]

Attachment: update.log

This is just the update.log from within the file in comment 5.

Comment 7

[Justin Dolske [:Dolske]]

Finally, perhaps coincidence, but I noticed that a fresh download of nightly has "Firefox Nightly.app" (with a space), whereas my broken app was still just "FirefoxNightly.app" (without a space).

Bug 1378834 hasn't landed yet, but Sylvestre says he did just land bug 1407285. Could be a red herring, but FWIW.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1423856 - Remove the space in the .app files to fix a potential update issue

Review commit: https://reviewboard.mozilla.org/r/206430/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206430/

Comment 9

[Mike Hommey [:glandium]]

Comment on attachment 8935553 [details]
Bug 1423856 - Remove the space in the .app files to fix a potential update issue

https://reviewboard.mozilla.org/r/206430/#review212074

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f6d2b219c78
Remove the space in the .app files to fix a potential update issue r=glandium

Comment 11

[Justin Dolske [:Dolske]]

Also, FTR, from IRC it sounded like this somehow ended up only affecting complete updates, and not partials (which is why some people were able to update to the current nightly without any problem).

As a quick test, I confirmed that downloading an old Nightly and checking for updates reproduced the problem. The old Nightly quits, but the updater never seemed to come up and the resulting FirefoxNighty.app was unlaunchable and empty per comment 3. (Finder gave me a slightly different error when trying to launch, but not sure if that matters.)

I was trying with a build I found from September:

http://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/firefox-57.0a1.en-US.mac.dmg

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/ec94a5c11a0a
Remove the space in the .app files to fix a potential update issue. r=glandium, a=RyanVM

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3f6d2b219c78

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Justin, could you double check that my patch fixed the issue?
Merci!

Comment 15

[Jordan Lund (:jlund)]

(In reply to Justin Dolske [:Dolske] from comment #11)
> Also, FTR, from IRC it sounded like this somehow ended up only affecting
> complete updates, and not partials (which is why some people were able to
> update to the current nightly without any problem).
> 

given this, I suspect bug 1423571 is related.

Comment 16

[Jordan Lund (:jlund)]

(In reply to Justin Dolske [:Dolske] from comment #7)
> Finally, perhaps coincidence, but I noticed that a fresh download of nightly
> has "Firefox Nightly.app" (with a space), whereas my broken app was still
> just "FirefoxNightly.app" (without a space).
> 
> Bug 1378834 hasn't landed yet, but Sylvestre says he did just land bug
> 1407285. Could be a red herring, but FWIW.

I may have jumped the gun here. If this is mac only and specifically this issue, bug 1423571 is just a big coincidence?

Comment 17

[Sylvestre Ledru [:Sylvestre]]

Yeah, my change is nightly only and bug 1423571 impacts beta! :)

Comment 18

[Molly Howell (she/her) (mostly inactive)]

Yeah, I don't think bug 1423571 is related to this; in addition to what Sylvestre pointed out, that bug has to do with downloading the MAR, and in this bug it's already been downloaded and the updater has partially applied it.

Comment 19

[Sylvestre Ledru [:Sylvestre]]

Dolkse, it seems that the actual issue was caused by bug 1424294.
I will probably revert https://hg.mozilla.org/mozilla-central/rev/3f6d2b219c78 next week.

Comment 20

[Nick Alexander :nalexander [he/him]]

(In reply to Justin Dolske [:Dolske] from comment #11)
> Also, FTR, from IRC it sounded like this somehow ended up only affecting
> complete updates, and not partials (which is why some people were able to
> update to the current nightly without any problem).
> 
> As a quick test, I confirmed that downloading an old Nightly and checking
> for updates reproduced the problem. The old Nightly quits, but the updater
> never seemed to come up and the resulting FirefoxNighty.app was unlaunchable
> and empty per comment 3. (Finder gave me a slightly different error when
> trying to launch, but not sure if that matters.)
> 
> I was trying with a build I found from September:
> 
> http://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/
> firefox-57.0a1.en-US.mac.dmg

I saw this, and observed that I was missing `MacOS/firefox` or `MacOS/firefox-bin`, whatever the main executable was.  I downloaded a fresh Nightly DMG and re-installed.

Comment 21

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d8bb8542b3d23f2b590f9c2b1cb9215219527df
Bug 1423856 - Backed out changeset 3f6d2b219c78. Fixed in bug 1424294 r=me

Comment 22

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d94f6fad91e4
Backed out 5 changesets (bug 1423856, bug 1404796, bug 1378834, bug 1404823) for build bustages on compare-mozconfigs-wrapper.py r=backout on a CLOSED TREE

Comment 23

[Cosmin Sabou [:CosminS]]

Backed out for build bustages on ../build/compare-mozconfig/compare-mozconfigs-wrapper.py::TestCompareMozconfigs::test_compare_mozconfigs

Treeheder link with the push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=8d8bb8542b3d23f2b590f9c2b1cb9215219527df&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/d94f6fad91e42260b0a93f097bb38d93aea41970

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=152720370&repo=mozilla-inbound&lineNumber=30264

Comment 24

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5d8ae8c4ee4a990177c6cf6a3362e73fad9cc554
Bug 1423856 - Backed out changeset 3f6d2b219c78. Fixed in bug 1424294 r=me

Comment 25

[Dorel Luca [:dluca]]

 Backed out changeset 5d8ae8c4ee4a (bug 1423856) for failing Browser-chrome on toolkit/xre/test/browser_checkdllblockliststate.js on a CLOSED TREE 

https://treeherder.mozilla.org/logviewer.html#?job_id=152893594&repo=mozilla-inbound&lineNumber=6086

https://hg.mozilla.org/integration/mozilla-inbound/rev/8f8ef0ab92abef8047250613116bc72b37375683

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=40eb00c21e7c776d4781c28e88a9b0917b4396ce&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&selectedJob=152893594

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/411a410f23b4
Backed out changeset 3f6d2b219c78. Fixed in bug 1424294 r=me

Comment 27

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/411a410f23b4

Comment 28

[Nick Alexander :nalexander [he/him]]

My Nightly was busted this morning, and I had to fetch it again from nightly.mozilla.org.  (Mac OS X.)  Is this 'cuz we relanded and are still broken?

Comment 29

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c25a7460cbeb5021a1e4913efa8b500bcfb462ab
Bug 1423856 - Backed out changeset 411a410f23b4. Seems that bug 1424294 wasnt' enough to fix it r=me

Comment 30

[Sylvestre Ledru [:Sylvestre]]

I thought that bug 1424294 fixed it... Looks like we are not running everything in the CI for nightly updates.
I just backout this change.

Comment 31

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/c25a7460cbeb5021a1e4913efa8b500bcfb462ab

Comment 32

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #30)
> I thought that bug 1424294 fixed it... Looks like we are not running
> everything in the CI for nightly updates.
> I just backout this change.
OS X nightlies are busted since Friday, bug 1410148.

Comment 33

[Sylvestre Ledru [:Sylvestre]]

> OS X nightlies are busted since Friday, bug 1410148.
So, you mean this isn't my fault?

Comment 34

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The OS X opt builds are broken, so no update generation etc. will run on OS X. Updates of current installations should end up with https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=0843e4e6cb1d6e32a35ce4d7014bd250c24f74fa&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=retry&filter-resultStatus=success&filter-searchStr=macos from Thursday.

The first push with the failure is https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=d20967c26da559a7781db467741bb240af9bfe5c&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=retry&filter-resultStatus=success&filter-searchStr=macos and there is no commit by you in it. Your changes are unrelated to the issue which breaks OS X builds on central at the moment.

Comment 35

[Sylvestre Ledru [:Sylvestre]]

I opened bug 1427000 as a follow up bug.

Comment 36

[Justin Dolske [:Dolske]]

Pretty sure I no longer need to verify comment 14 is working. :)