Use a sparse profile for upload-generated-sources tasks

RESOLVED FIXED in Firefox 59

Status

()

Core
Build Config
RESOLVED FIXED
2 months ago
a month ago

People

(Reporter: ted, Assigned: ted)

Tracking

unspecified
mozilla59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 months ago
I added upload-generated-sources tasks in bug 1259832, and they use `run-task` to run an in-tree script with `mach python`, which is handy for not having to jump through hoops to make things work. We can make this better by using a sparse profile to checkout fewer files.

I pushed this patch to try and the resulting Ugs job for linux64-opt took 4 minutes:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=236aaff03265c2e430023c695545efe8ecb71cd9&selectedJob=150488302

That's a full minute faster than the latest linux64-opt Ugs run I found on central:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-searchStr=nightly&selectedJob=150455104
(Assignee)

Comment 1

2 months ago
To be more precise, the Ugs task on my try push took 214.3 seconds, and the Ugs task on that nightly build on central took 292.4 seconds, so it's a bit more than a minute (but probably subject to some variability).
Comment hidden (mozreview-request)
(Assignee)

Comment 3

2 months ago
This patch adds an `upload-generated-sources` sparse profile which is just the `mach` profile but with a single Python script added. Alternately, I could just add that single Python script to the `mach` profile to avoid adding a new sparse profile. I think either way is probably OK.

Comment 4

a month ago
mozreview-review
Comment on attachment 8935355 [details]
bug 1423882 - Define and use a sparse profile for upload-generated-sources tasks.

https://reviewboard.mozilla.org/r/206250/#review212600
Attachment #8935355 - Flags: review?(gps) → review+

Comment 5

a month ago
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b77cca253e5
Define and use a sparse profile for upload-generated-sources tasks. r=gps

Comment 6

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7b77cca253e5
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.