1423911 - Update cargo-vendor version requirement.

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Emilio Cobos Álvarez [:emilio]]

Otherwise it will spuriously reintroduce libudev-sys from crates.io in the build, as just happen on autoland.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

(This is my fault, I was running a newer version of cargo-vendor locally than what the vcs-sync bot is running, so I didn't catch the error when I tested/landed bug 1423236). cargo-vendor 0.1.12 doesn't deal with [patch] properly but 0.1.13 does.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1423911: Update cargo-vendor requirement.

Review commit: https://reviewboard.mozilla.org/r/206282/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206282/

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8935379 [details]
Bug 1423911: Update cargo-vendor requirement.

https://reviewboard.mozilla.org/r/206282/#review211876

::: python/mozbuild/mozbuild/vendor_rust.py:42
(Diff revision 1)
> -        Ensure that cargo-vendor is new enough. cargo-vendor 0.1.12 and newer
> +        Ensure that cargo-vendor is new enough. cargo-vendor 0.1.13 and newer
>          strips out .cargo-ok, .orig and .rej files which we want.

Update comment:

"... and newer deal with [patch] replacements in Cargo.toml files which we want"

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8935379 [details]
Bug 1423911: Update cargo-vendor requirement.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/206282/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/634f6b38e17a
Update cargo-vendor requirement. r=kats

Comment 6

[Mozilla Autoland]

We're sorry - something has gone wrong while rewriting or rebasing your commits. The commits being pushed no longer match what was requested. Please file a bug.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

(In reply to Mozilla Autoland from comment #6)
> We're sorry - something has gone wrong while rewriting or rebasing your
> commits. The commits being pushed no longer match what was requested. Please
> file a bug.

This is just because emilio pushed it manually on a closed tree, after we put it in the autoland queue.

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/634f6b38e17a