1423934 - 'Firefox Nightly' for both brandShortName and brandFullName

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P3)

Description

[Adrian Florinescu [:aflorinescu] [PTO until 04.23 ]]

Currently in m-c, the brandShortName and brandFullName are the same:'Nightly', bug 1378834 fix changing the brandFullName to 'Firefox Nightly'. From the user facing point of view, the brandFullName impacts only a few areas, more predominant across the app. being the brandShortName.

Once I got hold of that oak build with the bug 1378834 fix and started testing it, having Nightly in most places raised the question why not both brandShortName and brandFullName shouldn't be 'Firefox Nightly', since the product is Firefox. 

Discussing this subject with :sylvestre, we got a try-build up that has brandShortName and brandFullName :'Firefox Nightly' (https://treeherder.mozilla.org/#/jobs?repo=oak&revision=d2efaf1a147c0c858190d49e29202ce0cf426d2c&filter-searchStr=build). Therefore, I've compared current Nightly build (left) with the try-build (right) and here's how it looks: https://imgur.com/a/5ppyK (don't know why the last image for help states 'Nightly' instead of 'Firefox Nightly' for the last comparison (right) -:sylvestre?)

:dao opens similar discussion here as well : https://bugzilla.mozilla.org/show_bug.cgi?id=1378834#c23, but as far as I figured, there is a different and probably a bit more complicated discussion to be had about the brandShortName and brandFullName usage across the other non-nightly channels.

Comment 1

[Adrian Florinescu [:aflorinescu] [PTO until 04.23 ]]

I think feedback from product would be required so Jeff, if you could please take a look?

Comment 2

[Jeff Griffiths (:canuckistani) (:⚡︎)]

I'd like feedback from Michele on this change.

Comment 3

[mheubusch]

Thanks for asking, Jeff! We have attempted to follow the marketing and product style guide which states "Firefox Nightly on the first mention, Nightly on subsequent mentions, always capitalized." Obviously "first mention" isn't always a perfect guideline in a product(vs. a marketing piece) but I think we should do a few things before we make a global change:

1. Make sure that this change will be made automatically everywhere - per your note and the examples, Adrian, I'm not sure it's as simple as changing the value of one variable. 

2. Audit all the channels to look at the impact. 

3. Align with marketing on the recommendation as they are in the midst of defining our brand hierarchy, so will probably have some thoughts on this and may want to make global changes coming out of their definition anyway.

4. Validate with l10n to understand the impact to their workflow.   

I'll take the next step of setting up a meeting to discuss item 1 - Adrian, I'll plan to include you - should anyone else be in that meeting?  I'll also get my team started on item 2 and expect that we can have an accurate picture in the next week or two.  Then, I can reach out to the brand team to discuss after. 

Please let me know if there are questions or concerns.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

With Adrian, I should also be part of this meeting as I have been driving the technical change for nightly. 

About 1. it will be automatic, this is what we have current what we have with devedition with a much longer string.
https://dxr.mozilla.org/mozilla-central/source/browser/branding/aurora/locales/en-US/brand.dtd?q=browser%2Fbranding%2Faurora%2Flocales%2Fen-US%2Fbrand.dtd&redirect_type=direct

About other channels, currently, we have:
- Nightly -
Short = Nightly
Long = Nightly
Adrian is proposing to have:
Short = Firefox Nightly
Long = Firefox Nightly

Dao suggested
Short = Nightly
Long = Firefox Nightly

- DevEdition - 
Short = Firefox Developer Edition
Long = Firefox Developer Edition

- Beta -
Short = Firefox
Long = Mozilla Firefox

- Release -
Short = Firefox
Long = Mozilla Firefox


For l10n, I am not expecting any issue as it is the same as we are doing on with other branches (devedition for example).

Comment 5

[mheubusch]

Following up here with immediate and near-term next steps:

1. Meridel audited channels to see how the two recommendations would play out.  Sylvestre and I met today to review her recommendation (which is also Dao's) to use "Firefox Nightly" as the long name and "Nightly" as the short name. 

2. Sylvestre will create a build with this - so we can see how it plays out fully and so relman can understand if it introduces bugs/regressions that will need to be addressed. 

3. Content strategy will work to address the broader issue of not using the same value for multiple variables - ie on Developer Edition, we use Firefox Developer Edition for long, short, and shorter names.

There is also the issue of defining a rationale for when we use long name vs short name vs shorter name vs vendor name+product name.

We'll outline a recommendation for terminology and use, then validate this with product management, marketing, legal, and localization.  

cc'ing stakeholders as a heads up.  

Sylvestre -  am I missing anything?

Comment 6

[Sylvestre Ledru [:Sylvestre]]

This is perfect. Happy to work with you on the short/long/vendor thing!

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Michelle, it landed in nightly!
QA is going to verify all that next week.
I haven't see any issue on Linux. An issue with Mac but it should be fixed with today's nightly.

Comment 8

[Adrian Florinescu [:aflorinescu] [PTO until 04.23 ]]

To add to this issue, from the OsX Firefox Nightly menu, we have About Nightly, Hide Nightly, Quit Nightly. IMO, there should be About Firefox Nightly, Hide Firefox Nightly, Quit Firefox Nightly.

Comment 9

[Francesco Lodolo [:flod]]

(In reply to Adrian Florinescu [:AdrianSV] from comment #8)
> To add to this issue, from the OsX Firefox Nightly menu, we have About
> Nightly, Hide Nightly, Quit Nightly. IMO, there should be About Firefox
> Nightly, Hide Firefox Nightly, Quit Firefox Nightly.

brandShorterName was introduced for DevEdition (bug 1099426).

While you'd get "Quit Firefox Nightly" in Nightly, it would become a staggering "Quit Firefox Developer Edition" if you use brandFullName.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Short & long is the same with devedition ( https://dxr.mozilla.org/mozilla-central/source/browser/branding/aurora/locales/en-US/brand.dtd ). Could be different to have something in the middle.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

AFAIK, we are happy about the current status.

Michelle, feel free to reopen the bug if you disagree!