Closed
Bug 1424014
Opened 7 years ago
Closed 7 years ago
Error 500 on hg.mozilla.org when pushing a commit with only " " (two spaces) as a commit message
Categories
(Developer Services :: Mercurial: hg.mozilla.org, enhancement)
Developer Services
Mercurial: hg.mozilla.org
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: padenot, Assigned: glob)
Details
Attachments
(1 file)
The command was `hg commit -m" "`.
Here is the commit: https://hg.mozilla.org/try/rev/a829615642c57e4eb3e06af6a9f9d8ab2c08a751
Two affected pushes:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4836c20a61a2984f2274a40f79fc2bc1300cd4d3
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4836c20a61a2984f2274a40f79fc2bc1300cd4d3
Then I did `hg commit --amend` and wrote a random string, re-pushed and it worked.
> mod_wsgi (pid=1286): Exception occurred processing WSGI script '/repo_local/mozilla/webroot_wsgi/hgweb.wsgi'.
> Traceback (most recent call last):
> File "/var/hg/venv_hgweb/lib/python2.7/site-packages/mercurial/hgweb/hgwebdir_mod.py", line 227, in run_wsgi
> for r in self._runwsgi(req):
> File "/var/hg/venv_hgweb/lib/python2.7/site-packages/mercurial/hgweb/hgweb_mod.py", line 324, in run_wsgi
> for r in self._runwsgi(req, repo):
> File "/var/hg/version-control-tools/hgext/serverlog/__init__.py", line 272, in _runwsgi
> for what in super(hgwebwrapped, self)._runwsgi(req, repo):
> File "/var/hg/venv_hgweb/lib/python2.7/site-packages/mercurial/hgweb/hgweb_mod.py", line 447, in _runwsgi
> content = getattr(webcommands, cmd)(rctx, req, tmpl)
> File "/var/hg/venv_hgweb/lib/python2.7/site-packages/mercurial/hgweb/webcommands.py", line 457, in changeset
> return tmpl('changeset', **webutil.changesetentry(web, req, tmpl, ctx))
> File "/var/hg/version-control-tools/hgext/hgmo/__init__.py", line 286, in changesetentry
> addmetadata(web.repo, ctx, d)
> File "/var/hg/version-control-tools/hgext/hgmo/__init__.py", line 195, in addmetadata
> for reviewer in commitparser.parse_reviewers(description):
> File "/var/hg/version-control-tools/pylib/mozautomation/mozautomation/commitparser.py", line 128, in parse_reviewers
> commit_summary = commit_description.splitlines().pop(0)
> IndexError: pop from empty list
Assignee: nobody → glob
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8935632 [details]
mozautomation: don't fail when parsing empty strings (bug 1424014)
https://reviewboard.mozilla.org/r/206510/#review212230
Attachment #8935632 -
Flags: review?(gps) → review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/627fe9a4e4b1
mozautomation: don't fail when parsing empty strings r=gps
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•