Closed Bug 1424015 Opened 8 years ago Closed 8 years ago

SkJumper_generated_win.obj is not built with -SAFESEH

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox59 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: away, Assigned: away)

References

Details

Attachments

(1 file, 2 obsolete files)

build SkJumper_generated_win with SAFESEH
1.77 KB, patch
away
: review+
Details | Diff | Splinter Review
MSVC's linker seems to let this slide but lld complains: 23:18:16 INFO - lld-link: error: /safeseh: ..\..\gfx\skia\SkJumper_generated_win.obj is not compatible with SEH
Attached patch End goal (obsolete) — — Splinter Review
This is the change I would like to effect, but I was told in very large letters to go away from this file. Any pointers on how to change generate_mozbuild.py to make this happen?
Assignee: nobody → dmajor
Attachment #8935476 - Flags: feedback?(ted)
It looks like you could just stick that verbatim right here: https://searchfox.org/mozilla-central/rev/f5f1c3f294f89cfd242c3af9eb2c40d19d5e04e7/gfx/skia/generate_mozbuild.py#443 Just use `f.write("whatever")` with the proper indentation and newlines.
Oh. How did I not see that D-:
Attached patch skjumper_safeseh (obsolete) — — Splinter Review
Attachment #8935476 - Attachment is obsolete: true
Attachment #8935476 - Flags: feedback?(ted)
Attachment #8937776 - Flags: review?(lsalzman)
It is better to just put the change in the footer, as the other sections of generate_mozbuild are only for blasting out the file lists.
Attachment #8937776 - Attachment is obsolete: true
Attachment #8937776 - Flags: review?(lsalzman)
Attachment #8937781 - Flags: review?(dmajor)
Comment on attachment 8937781 [details] [diff] [review] build SkJumper_generated_win with SAFESEH Ok, I have no huge preference.
Attachment #8937781 - Flags: review?(dmajor) → review+
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a9441c3bc91e Build SkJumper_generated_win.obj with -SAFESEH. r=dmajor
https://hg.mozilla.org/mozilla-central/rev/a9441c3bc91e
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: