Closed Bug 1424015 Opened 4 years ago Closed 4 years ago
Jumper _generated _win .obj is not built with -SAFESEH
MSVC's linker seems to let this slide but lld complains: 23:18:16 INFO - lld-link: error: /safeseh: ..\..\gfx\skia\SkJumper_generated_win.obj is not compatible with SEH
This is the change I would like to effect, but I was told in very large letters to go away from this file. Any pointers on how to change generate_mozbuild.py to make this happen?
Assignee: nobody → dmajor
Attachment #8935476 - Flags: feedback?(ted)
It looks like you could just stick that verbatim right here: https://searchfox.org/mozilla-central/rev/f5f1c3f294f89cfd242c3af9eb2c40d19d5e04e7/gfx/skia/generate_mozbuild.py#443 Just use `f.write("whatever")` with the proper indentation and newlines.
Oh. How did I not see that D-:
It is better to just put the change in the footer, as the other sections of generate_mozbuild are only for blasting out the file lists.
Comment on attachment 8937781 [details] [diff] [review] build SkJumper_generated_win with SAFESEH Ok, I have no huge preference.
Attachment #8937781 - Flags: review?(dmajor) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a9441c3bc91e Build SkJumper_generated_win.obj with -SAFESEH. r=dmajor
You need to log in before you can comment on or make changes to this bug.