1424025 - Replace widgets.css link with only breadcrumbs.css

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

We only need the breadcrumbs.css that is imported from widgets.css in the inspector.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1424025.patch

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=995849fa621e3eaa900e7f45f316d44f3397f1c7

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8935490 [details] [diff] [review]
1424025.patch

Review of attachment 8935490 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. R+ if try is green + comment addressed.

::: devtools/client/themes/widgets.css
@@ -2,5 @@
>  /* This Source Code Form is subject to the terms of the Mozilla Public
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
> -@import url(chrome://devtools/skin/breadcrumbs.css);

You can't remove the import from here, as it is used at least by the old debugger.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/efdfb9487b81
Replace widgets.css link with only breadcrumbs.css. r=jdescottes

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/efdfb9487b81