Closed Bug 1424074 Opened 7 years ago Closed 7 years ago

Register event listener earlier in browser_bug703210.js

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

Separated from bug 1421113.
it turns out that the intermittent failure in browser_bug703210.js can be fixed inside browser_bug703210.js itself.
so I'll fix it here.
Blocks: 1418184
Separated from bug 1421113 patch.
apparently just reordering the event registration fixed the issue.
Attachment #8935549 - Flags: review?(paolo.mozmail)
Comment on attachment 8935549 [details] [diff] [review]
Register event listener earlier in browser_bug703210.js.

Thanks a lot for looking into the issues with these tests :-)
Attachment #8935549 - Flags: review?(paolo.mozmail) → review+
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c819b56fe97
Register event listener earlier in browser_bug703210.js. r=Paolo
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c819b56fe973b077d64737db186b066850e1197
Bug 1424074 - Register event listener earlier in browser_bug703210.js. r=Paolo
Backout by dluca@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/af13a0c0ef0b
Backed out changeset 1c819b56fe97 for failing browser-chrome's browser/base/content/test/permissions/browser_temporary_permissions_expiry.js on Windows 7 debug without e10s  r=backout on a CLOSED TREE
Backed out changeset 1c819b56fe97 (bug 1424074) for failing browser-chrome's browser/base/content/test/permissions/browser_temporary_permissions_expiry.js on Windows 7 debug without e10s r=backout on a CLOSED TREE 

Failure push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=1c819b56fe973b077d64737db186b066850e1197&selectedJob=150891282&group_state=expanded

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=150929862&repo=mozilla-inbound&lineNumber=4084

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/af13a0c0ef0b31bc298358837411f122df7b8399
Flags: needinfo?(arai.unmht)
Flags: needinfo?(arai.unmht)
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0461bbecc8a2c0354202931c5a4a9abca354fcc
Bug 1424074 - Register event listener earlier in browser_bug703210.js. r=Paolo
https://hg.mozilla.org/mozilla-central/rev/c0461bbecc8a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: