Closed Bug 1424103 Opened 2 years ago Closed 2 years ago

constexpr-ify mozilla::Span

Categories

(Core :: MFBT, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: emk, Assigned: emk)

Details

Attachments

(1 file)

Now we can assume C++14 support.
Comment on attachment 8936127 [details]
Bug 1424103 - constexpr-ify mozilla::Span.

https://reviewboard.mozilla.org/r/206900/#review213496

Thanks.
Attachment #8936127 - Flags: review?(hsivonen) → review+
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/6af18d0f2aaf
constexpr-ify mozilla::Span. r=hsivonen
https://hg.mozilla.org/mozilla-central/rev/6af18d0f2aaf
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
This breaks the build for me with my Clang:

js/src/dbg64opt/dist/include/mozilla/Span.h:793:5: error: statement not allowed in constexpr function
    MOZ_RELEASE_ASSERT(idx < storage_.size());

I'll try to update my Clang 4.0.1...
Nevermind, nuking my SpiderMonkey objdir seems to have fixed it.
Assignee: nobody → VYV03354
You need to log in before you can comment on or make changes to this bug.