1424115 - Rewrite test_animation_observers_async.html with testharness.js

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

I started this since I was hoping this fixes 'finish_from_pause' failure with a patch for bug 1416966, but unfortunately it's not.  Even it did not help it at all, it's worth doing I think.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=32011965628cf4732691e4c165a06c07412ed07a

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1424115 - Drop requestLongerTimeout in test_animation_observers_async.html.

Most of test cases in the test file has been moved so that the test no longer
takes over default time out (5 minutes).

Review commit: https://reviewboard.mozilla.org/r/206492/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206492/

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1424115 - Fix indentation in test_animation_observers_sync.html.

Review commit: https://reviewboard.mozilla.org/r/206494/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206494/

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1424115 - Drop EventUtils.js from test_animation_observers_async.html.

It's no longer used.

Review commit: https://reviewboard.mozilla.org/r/206496/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206496/

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1424115 - Rewrite test_animation_observers_async.html with promise_test.

With this patch we still use a global MutationObserver and a single target
element and re-use them in all test cases.  Eventually each test should create
a target element and a MutationObserver to avoid explicit cleanup jobs (e.g.
clearing styles and flushing styles for the global target element), but it's
not in the scope of this bug.

Review commit: https://reviewboard.mozilla.org/r/206498/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206498/

Comment 5

[Boris Chiou [:boris]]

Comment on attachment 8935613 [details]
Bug 1424115 - Drop requestLongerTimeout in test_animation_observers_async.html.

https://reviewboard.mozilla.org/r/206492/#review212238

Comment 6

[Boris Chiou [:boris]]

Comment on attachment 8935614 [details]
Bug 1424115 - Fix indentation in test_animation_observers_sync.html.

https://reviewboard.mozilla.org/r/206494/#review212240

Comment 7

[Boris Chiou [:boris]]

Comment on attachment 8935615 [details]
Bug 1424115 - Drop EventUtils.js from test_animation_observers_async.html.

https://reviewboard.mozilla.org/r/206496/#review212244

Comment 8

[Boris Chiou [:boris]]

Comment on attachment 8935616 [details]
Bug 1424115 - Rewrite test_animation_observers_async.html with promise_test.

https://reviewboard.mozilla.org/r/206498/#review212260

Cool. Looks much better.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9439a775a8d8
Drop requestLongerTimeout in test_animation_observers_async.html. r=boris
https://hg.mozilla.org/integration/autoland/rev/b106561a9ba1
Fix indentation in test_animation_observers_sync.html. r=boris
https://hg.mozilla.org/integration/autoland/rev/cc301e9aa700
Drop EventUtils.js from test_animation_observers_async.html. r=boris
https://hg.mozilla.org/integration/autoland/rev/a848673638d6
Rewrite test_animation_observers_async.html with promise_test. r=boris

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/9439a775a8d8
https://hg.mozilla.org/mozilla-central/rev/b106561a9ba1
https://hg.mozilla.org/mozilla-central/rev/cc301e9aa700
https://hg.mozilla.org/mozilla-central/rev/a848673638d6