Closed Bug 1424115 Opened 6 years ago Closed 6 years ago

Rewrite test_animation_observers_async.html with testharness.js

Categories

(Core :: DOM: Animation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: hiro, Assigned: hiro)

Details

Attachments

(4 files)

I started this since I was hoping this fixes 'finish_from_pause' failure with a patch for bug 1416966, but unfortunately it's not.  Even it did not help it at all, it's worth doing I think.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=32011965628cf4732691e4c165a06c07412ed07a
Comment on attachment 8935613 [details]
Bug 1424115 - Drop requestLongerTimeout in test_animation_observers_async.html.

https://reviewboard.mozilla.org/r/206492/#review212238
Attachment #8935613 - Flags: review?(boris.chiou) → review+
Comment on attachment 8935614 [details]
Bug 1424115 - Fix indentation in test_animation_observers_sync.html.

https://reviewboard.mozilla.org/r/206494/#review212240
Attachment #8935614 - Flags: review?(boris.chiou) → review+
Comment on attachment 8935615 [details]
Bug 1424115 - Drop EventUtils.js from test_animation_observers_async.html.

https://reviewboard.mozilla.org/r/206496/#review212244
Attachment #8935615 - Flags: review?(boris.chiou) → review+
Comment on attachment 8935616 [details]
Bug 1424115 - Rewrite test_animation_observers_async.html with promise_test.

https://reviewboard.mozilla.org/r/206498/#review212260

Cool. Looks much better.
Attachment #8935616 - Flags: review?(boris.chiou) → review+
Assignee: nobody → hikezoe
Status: NEW → ASSIGNED
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9439a775a8d8
Drop requestLongerTimeout in test_animation_observers_async.html. r=boris
https://hg.mozilla.org/integration/autoland/rev/b106561a9ba1
Fix indentation in test_animation_observers_sync.html. r=boris
https://hg.mozilla.org/integration/autoland/rev/cc301e9aa700
Drop EventUtils.js from test_animation_observers_async.html. r=boris
https://hg.mozilla.org/integration/autoland/rev/a848673638d6
Rewrite test_animation_observers_async.html with promise_test. r=boris
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: