Closed Bug 1424172 Opened 6 years ago Closed 6 years ago

mDrawTargetsToFlush will grow forever with Tiled OMTP

Categories

(Core :: Graphics: Layers, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: rhunt, Assigned: rhunt)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

Assuming that bug 1422392 will make it to central, I noticed that we append to 'mDrawTargetsToFlush' in AsyncPaintTiledContents. This is the same behavior as AsyncPaintContents and it is expected that AsyncEndLayer will then perform all the flushes. The only problem is that AsyncEndLayer is not called by tiled painted layers.

Looking at it further, there is no reason that we need to defer flushing draw targets with tiled layers, and so we should just do the flushing immediately.

Maybe it's not even necessary? The fact we don't flush right now hasn't caused any bugs or test failures.
Attachment #8935665 - Flags: review?(dvander) → review?(bas)
Comment on attachment 8935665 [details]
Don't append to mDrawTargetsToFlush in Tiled OMTP (bug 1424172, )

https://reviewboard.mozilla.org/r/206566/#review212418
Attachment #8935665 - Flags: review?(bas) → review+
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f6eb9518ea74
Don't append to mDrawTargetsToFlush in Tiled OMTP (bug 1424172, r=bas)
https://hg.mozilla.org/mozilla-central/rev/f6eb9518ea74
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: