Closed Bug 1424216 Opened 8 years ago Closed 8 years ago

Support directories as input to lcov_rewriter

Categories

(Testing :: Code Coverage, enhancement)

enhancement
Not set
normal

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: marco, Assigned: marco)

Details

Attachments

(1 file, 1 obsolete file)

The lcov rewriter accepts a list of files as input. It would be nice to support a directory containing info files too, to avoid a huge parameter list.
Attached patch Patch (obsolete) — Splinter Review
Attachment #8935727 - Flags: review?(cmanchester)
Attached patch PatchSplinter Review
Attachment #8935727 - Attachment is obsolete: true
Attachment #8935727 - Flags: review?(cmanchester)
Attachment #8935733 - Flags: review?(cmanchester)
Attachment #8935733 - Flags: review?(cmanchester) → review+
Pushed by mcastelluccio@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/50f8950fc2bc Support passing directories as inputs to lcov_rewriter.py. r=chmanchester
This busted many platforms on inbound: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=cc0a899aa73a7332e2d31cf96ceb4c2030e92a8a Sample log (which includes "/python/mozbuild/mozbuild/test/codecoverage/test_lcov_rewrite.py::TestLcovParser::test_basic_parse TEST-UNEXPECTED-FAIL" and other lcov-releated failure output): https://treeherder.mozilla.org/logviewer.html#?job_id=150953658&repo=mozilla-inbound&lineNumber=33826 Backing out shortly.
Pushed by mcastelluccio@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/53ed0617f39c Support passing directories as inputs to lcov_rewriter.py. r=chmanchester
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: