1424234 - Fix styling of individuals-button in Memory tool

Status: NEW

(DevTools :: Memory, defect, P3)

Description

[magicp]

Attachment: individuals-button.png

Steps to reproduce:
1. Open Memory tool (Unfortunately no shortcut key, no web developer menu...)
2. Take snapshot
3. Switch view to "Aggregate"
4. Select any tree nodes
5. Confirm individuals-button styling

Actual Results:
individuals-button does not fit tree node styling.

Expected Results:
Previous style.

Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5291605468b85f824823b167b8a8006c87afe0f2&tochange=c5aedf62e0af308f076dd65d6775a566dea6365a

Comment 1

[magicp]

Attachment: individuals-button.png

Comment 2

[Sagar Bharadwaj]

I'd like to take this up as one of my first bugs. Would that be okay?

Comment 3

[Sagar Bharadwaj]

Attachment: Bug 1424234 - Fixing styling of individuals button in Memory tool

Added new CSS selector

Review commit: https://reviewboard.mozilla.org/r/206908/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206908/

Comment 4

[Sagar Bharadwaj]

I have created a mozreview-request for this bug. Can you please review it?

Comment 5

[Julien Wajsberg [:julienw]]

Comment on attachment 8936150 [details]
Bug 1424234 - Fixing styling of individuals button in Memory tool

Putting a r? request for Greg.

Sagar, thanks for your contribution. Please note we're in a week long meeting with our team, and then it's the holiday period. I surely hope Greg will be able to look at your patch this week, but please be patient otherwise.

Thanks again !

Comment 6

[Sagar Bharadwaj]

No problem Julien.

Comment 7

[Greg Tatum [:gregtatum]]

Comment on attachment 8936150 [details]
Bug 1424234 - Fixing styling of individuals button in Memory tool

https://reviewboard.mozilla.org/r/206908/#review215410

::: devtools/client/themes/memory.css:437
(Diff revision 1)
>  .heap-tree-item.focused ::-moz-selection {
>    background-color: var(--theme-selection-color);
>    color: var(--theme-selection-background);
>  }
>  
> +.heap-tree-item.focused > .heap-tree-item-individuals > .individuals-button {

Thanks for handling this tweak! Your patch got caught in the middle of some time off, but now we're all back!

Would you mind changing the selector to not have descendant selectors? You may need to add an additional class to the button like "heap-tree-item-button".

Comment 8

[Greg Tatum [:gregtatum]]

Comment on attachment 8936150 [details]
Bug 1424234 - Fixing styling of individuals button in Memory tool

https://reviewboard.mozilla.org/r/206908/#review215412

I'm clearing the review flag for now so it won't show up on my to-do list.

Comment 9

[Sagar Bharadwaj]

(In reply to Greg Tatum [:gregtatum] [@gregtatum] from comment #7)
> Comment on attachment 8936150 [details]
> Bug 1424234 - Fixing styling of individuals button in Memory tool
> 
> https://reviewboard.mozilla.org/r/206908/#review215410
> 
> ::: devtools/client/themes/memory.css:437
> (Diff revision 1)
> >  .heap-tree-item.focused ::-moz-selection {
> >    background-color: var(--theme-selection-color);
> >    color: var(--theme-selection-background);
> >  }
> >  
> > +.heap-tree-item.focused > .heap-tree-item-individuals > .individuals-button {
> 
> Thanks for handling this tweak! Your patch got caught in the middle of some
> time off, but now we're all back!
> 
> Would you mind changing the selector to not have descendant selectors? You
> may need to add an additional class to the button like
> "heap-tree-item-button".

Yes. I'll do that and update my patch

Comment 10

[Patrick Brosset <:pbro>]

This bug has not been updated in the last 6 months. Resetting the assignee field.
Please, feel free to pick it up again and add a comment outlining your plans for it if you do still intend to work on it.
This is just trying to clean our backlog of bugs and make bugs available for people.