Closed
Bug 1424252
Opened 7 years ago
Closed 7 years ago
No text selection on pages with HTML context menus
Categories
(Firefox for Android Graveyard :: Text Selection, defect)
Tracking
(firefox60 verified)
RESOLVED
FIXED
Firefox 60
Tracking | Status | |
---|---|---|
firefox60 | --- | verified |
People
(Reporter: pftbest, Assigned: esawin)
References
Details
(Whiteboard: [specification][type:bug])
Attachments
(1 file, 2 obsolete files)
3.63 KB,
patch
|
cnevinchen
:
review+
|
Details | Diff | Splinter Review |
What did you do?
================
1. Open Firefox for Android version 56
2. visit https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent/Firefox
3. Try to select some text to copy
What happened?
==============
Popup appers with options to edit the text or view page history
What should have happened?
==========================
It should be possible to select some text and copy it.
Is there anything else we should know?
======================================
I had to use Google Chrome just to copy one line of text from this website, this is ridiculous.
Comment 1•7 years ago
|
||
developer.mozilla.org is using a contextmenu on the <body>. The <menu> edit-history-menu has two items, "Edit page" and "View page history". On Desktop Firefox, this adds these items to the "right-click" menu, but allows other default items such as "View Page Source" to still be available. It appears the on Firefox for Android, it may replace the context menu instead.
The contextmenu attribute is not supported in Chrome or other browsers:
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/contextmenu#Browser_compatibility
OS: Other → Android
Product: Mozilla Developer Network → Firefox for Android
Hardware: All → Unspecified
Version: unspecified → Firefox 56
Comment 2•7 years ago
|
||
I was able to reproduce with Nexus 5 (Android 6.0.1) on latest nightly build. Marking the bug as New.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Updated•7 years ago
|
status-firefox59:
--- → affected
Comment 3•7 years ago
|
||
Hi snorp
Could someone in your team help look at this?
Thanks!
Component: General → Text Selection
Flags: needinfo?(snorp)
There's work in Gecko to remove the <menu> functionality. We could preemptively stop supporting it in Fennec/GV. Eugen, you've looked at this before, wanna nuke it?
Flags: needinfo?(snorp) → needinfo?(esawin)
Assignee | ||
Comment 5•7 years ago
|
||
Remove HTML contextmenu support in Fennec.
We don't support <menu> in GV afaik, so there is nothing to do there.
Attachment #8940829 -
Flags: review?(snorp) → review?(cnevinchen)
Keywords: dev-doc-needed
See Also: → 1372276
Comment 6•7 years ago
|
||
Comment on attachment 8940829 [details] [diff] [review]
0001-Bug-1424252-1.0-Remove-menu-support-in-Fennec.-r-sno.patch
Thanks!
Attachment #8940829 -
Flags: review?(cnevinchen) → review+
Assignee | ||
Comment 7•7 years ago
|
||
Updated r=nechen.
Attachment #8940829 -
Attachment is obsolete: true
Attachment #8941523 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/df5c47596915
Remove <menu> support in Fennec. r=nechen
Keywords: checkin-needed
Comment 9•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Updated•7 years ago
|
Summary: It's not possible to select and copy text using mobile Firefox → Remove obsolete html5 attribute contextmenu from Fennec
Comment 10•7 years ago
|
||
As noted in bug 1429757, this breaks the context menus for about:downloads, about:addons and about:config [1].
[1] https://dxr.mozilla.org/mozilla-central/search?q=path%3Amobile+%3Cmenu+-path%3Asrc%2Fmain%2Fres+-path%3A.java&redirect=false
Assignee | ||
Updated•7 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 11•7 years ago
|
||
backout bugherder |
Backed out changeset df5c47596915 (bug 1424252) for causing bug 1429757
https://hg.mozilla.org/mozilla-central/rev/d4d53f4069f4
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Status: RESOLVED → REOPENED
status-firefox59:
fixed → ---
Resolution: FIXED → ---
Target Milestone: Firefox 59 → ---
Comment 12•7 years ago
|
||
Backed out changeset df5c47596915 (bug 1424252) for causing bug 1429757
https://hg.mozilla.org/mozilla-central/rev/d4d53f4069f43eab1aae8bcf4def08bdb5a84d8d
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=df5c47596915
Flags: needinfo?(esawin)
Assignee | ||
Comment 13•7 years ago
|
||
Since we can't immediately remove <menu> support, we need to mitigate the issue described in comment 0.
This is a somewhat ugly solution we could apply during the transition (until bug 1431512 is fixed).
The patch would allow for both, the HTML context menu and the text selection dialogs to pop up for text and other non-link elements, which would at least make text selection an option after discarding the HTML context menu.
Flags: needinfo?(esawin)
Attachment #8943968 -
Flags: review?(cnevinchen)
Assignee | ||
Updated•7 years ago
|
Summary: Remove obsolete html5 attribute contextmenu from Fennec → No text selection on pages with HTML context menus
Assignee | ||
Comment 14•7 years ago
|
||
I've moved out the removal of <menu> support to bug 1431759.
Assignee | ||
Updated•7 years ago
|
Attachment #8941523 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Keywords: dev-doc-needed
Updated•7 years ago
|
Attachment #8943968 -
Flags: review?(cnevinchen) → review+
Comment 16•7 years ago
|
||
Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb9d29d5f5bd
[2.0] Enable text selection complementary to the HTML or native context menu. r=nechen
Comment 17•7 years ago
|
||
bugherder |
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Comment 18•7 years ago
|
||
Tested with Nexus 5 (Android 6.0.1) and Google Pixel (Android 8.0) following the steps from description and the issue is fixed on latest Nightly build. Fixed meaning that the both menus are displayed when selecting a word.
On Nexus 5 the HTML context menu is displayed only once, but on Pixel every time a word is selected. Tested also text selection dialog and I was able to copy/share/select/search. Marking status 60:verified.
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•