1424259 - [Nightly] Text and icon from the sidebar switcher menu are wrongly aligned to the left and the icon is replaced with a "check" sign when selecting Firefox Notes experiment

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Carmen Fat [:cfat] - Ecosystem QA]

Attachment: test.gif

[Affected versions]:
- Firefox Nightly 59.0a1

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- Have a Firefox profile with "Firefox Notes" v2.0.0rc2 installed.

[Steps to reproduce]:
1. Open the browser with the profile from prerequisites.
2. Click on the sidebars switch button and observe the way that "Notes" sidebar option is displayed.
BONUS:
3. Click on the "Notes" option from the drop down.
4. Click again on the sidebars switch button and observe the way that "Notes" sidebar option is displayed.

[Expected result]:
2. "Notes" text and icon are displayed centered and aligned with the rest of the sidebars.
4. A "check" sign is displayed on the left side of the "Notes" icon.

[Actual result]:
2. "Notes" text and icon are displayed to the left and are not aligned with the rest of the sidebars.
4. The "check" sign is displayed instead of the "Notes" icon.

[Additional Notes]:
- Attached is a screencast of the issue.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Ryan, can you help this get prioritized? I recall you were working on Notes but I'm not sure who else is. It looks like we're using the wrong button type here.

Andrew, is this a webextensions-specific issue?

Comment 2

[Andrew Swan [:aswan]]

I don't know if this is specific to webextensions, redirect to the sidebar expert

Comment 3

[Ryan Feeley [:rfeeley]]

Oh my, I did notice this. Thanks to Carmen for finding this one. This would affect all add-ons using the sidebar I assume. Could get pretty confusing if an add-on used a checkmark as their icon. I know Mark Striemer will be working a related bug (adding the add-ons keyboard shortcut into the menu).

Mark is this related? It would affect all add-ons users I'm assuming.

Comment 4

[Mark Striemer [:mstriemer]]

Attachment: Bug 1424259 - Fix alignment of extension sidebar action icons

Review commit: https://reviewboard.mozilla.org/r/212266/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212266/

Comment 5

[Mark Striemer [:mstriemer]]

Attachment: sidebaraction-icon-alignment.mov.gif

I put a fix together for this. There are some failing tests locally that I haven't been able to figure out. I'll take a look at them again in the morning.

Comment 6

[Mark Striemer [:mstriemer]]

Comment on attachment 8942055 [details]
Bug 1424259 - Fix alignment of extension sidebar action icons

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/212266/diff/1-2/

Comment 7

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8942055 [details]
Bug 1424259 - Fix alignment of extension sidebar action icons

https://reviewboard.mozilla.org/r/212266/#review218908

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db5c4c3edbda
Fix alignment of extension sidebar action icons r=mixedpuppy

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/db5c4c3edbda

Comment 10

[Sajedul Islam]

I have reproduced this bug with Nightly 59.0a1 (2017-12-08) on Windows 10 , 64 Bit ! 

This bug's fix is Verified with latest Beta !

Build   ID    20180201171410
User Agent    Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0

[bugday-20180131]

Comment 11

[Mohammed Adam]

I have Reproduced this bug with Firefox Nightly 60.0a1 (2018-02-07) on Windows 7, (32bit) 

Steps to Reproduce: 

1) With a Firefox Profile, I have enabled the "Notes" from https://testpilot.firefox.com/experiments/notes/ 
2) Clicked on the sidebars "switch button"
3) I have Observed that "Notes" sidebar option is displayed
4) Then I Clicked on the "Notes" option from the Drop down.
5) And Click again on the sidebars swith button and Observed the way that "Notes" sidebar option is displayed. 

Actual Results:
1) "Notes" text and icon are displayed centered and aligned with the rest of the sidebars.
2) A "Check" sign is displayed on the left side of the "Notes" icon. 

This Bug is Verified with Latest Beta too. 

Status: Fixed & Verified

FirefoxVersion:60.0a1
Build ID: 20180206100151
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:60.0) Gecko/20100101 Firefox/60.0
OS: Windows_NT 6.1


[bugday-20180207]

Comment 12

[Mohammed Adam]

I Have tried to Reproduce the Same Bug in Firefox Nightly  60.0a1 (2018-02-20) on Windows 7 (32bit)
------------------------------------------------------------------------------------------
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:60.0) Gecko/20100101 Firefox/60.0
OS: Windows_NT 6.1
Build ID: 20180220220044
Firefox Version:60.0a1
------------------------------------------------------------------------------------------

But the Bug is Fixed 

This Bug is Fixed and Verified with Latest Beta too. 
------------------------------------------------------------------------------------------
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:59.0) Gecko/20100101 Firefox/59.0
OS: Windows_NT 6.1
Build ID: 20180219114835
Firefox Version:59.0b11
------------------------------------------------------------------------------------------

[Steps to Reproduce]
1) With a Cleaned Firefox Profile, I have enabled the "Notes" from https://testpilot.firefox.com/experiments/notes/ 
2) Clicked on the sidebars "switch button"
3) I have Observed that "Notes" sidebar option is displayed
4) Then I Clicked on the "Notes" option from the Drop down.
5) And Click again on the sidebars swith button and Observed the way that "Notes" sidebar option is displayed

[Actual Results]
1) "Notes" text and icon are displayed centered and aligned with the rest of the sidebars.
2) A "Check" sign is displayed on the left side of the "Notes" icon.

Status: Fixed & Verified 

[bugday-20180221]

Comment 13

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Marking this as Verified based on comment 12.