Open Bug 1424271 Opened 6 years ago Updated 2 years ago

Move some more Web Audio API tests from mochitest to web-platform-tests

Categories

(Core :: Web Audio, enhancement, P3)

57 Branch
enhancement

Tracking

()

People

(Reporter: alan.guyoch, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [need info padenot 2017-12-12])

Attachments

(12 files)

59 bytes, text/x-review-board-request
padenot
: review-
Details
59 bytes, text/x-review-board-request
padenot
: review+
Details
59 bytes, text/x-review-board-request
padenot
: review+
Details
59 bytes, text/x-review-board-request
padenot
: review+
Details
59 bytes, text/x-review-board-request
padenot
: review+
Details
59 bytes, text/x-review-board-request
padenot
: review+
Details
59 bytes, text/x-review-board-request
padenot
: review+
Details
59 bytes, text/x-review-board-request
Details
59 bytes, text/x-review-board-request
padenot
: review+
Details
59 bytes, text/x-review-board-request
padenot
: review+
Details
59 bytes, text/x-review-board-request
padenot
: review-
Details
59 bytes, text/x-review-board-request
padenot
: review+
Details
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171130135210
Component: Untriaged → Web Audio
Product: Firefox → Core
Paul, can you please handle this one?
Flags: needinfo?(padenot)
Whiteboard: [need info padenot 2017-12-12]
Assignee: nobody → alan.guyoch
Status: UNCONFIRMED → ASSIGNED
Rank: 25
Ever confirmed: true
Flags: needinfo?(padenot)
Priority: -- → P3
Summary: Move some Web Audio API tests from mochitest to web-platform-tests → Move some more Web Audio API tests from mochitest to web-platform-tests
Comment on attachment 8940614 [details]
Bug 1424271 - convert mochitest test_audioBufferSourceNodeLoopStartEnd.html to a web-platform-test

https://reviewboard.mozilla.org/r/210834/#review216642
Attachment #8940614 - Flags: review?(padenot) → review+
Comment on attachment 8940614 [details]
Bug 1424271 - convert mochitest test_audioBufferSourceNodeLoopStartEnd.html to a web-platform-test

https://reviewboard.mozilla.org/r/210834/#review216646
Comment on attachment 8940619 [details]
Bug 1424271 - convert mochitest test_AudioListener.html to a web-platform-test

https://reviewboard.mozilla.org/r/210844/#review216640

::: commit-message-ccbff:1
(Diff revision 1)
> +Bug 1424271 - convert mochitest test_AudioListener.html to a web-platform-test r?padenot

No need for this one, it's deprecated, and has been removed from the spec.
Attachment #8940619 - Flags: review?(padenot) → review-
Comment on attachment 8940619 [details]
Bug 1424271 - convert mochitest test_AudioListener.html to a web-platform-test

https://reviewboard.mozilla.org/r/210844/#review216648
Comment on attachment 8940610 [details]
Bug 1424271 - convert mochitest test_AudioBuffer.html to a web-platform-test

https://reviewboard.mozilla.org/r/210826/#review216638

::: testing/web-platform/tests/webaudio/the-audio-api/the-audiobuffer-interface/test_AudioBuffer.html:11
(Diff revision 1)
> +  <script src="/resources/testharnessreport.js"></script>
> +  <script>
> +var t = async_test();
> +var context = new AudioContext();
> +var buffer = context.createBuffer(2, 2048, context.sampleRate);
> +//SpecialPowers.gc(); // Make sure that our channels are accessible after GC

Remove this, we don't want comments here.
Attachment #8940610 - Flags: review?(padenot) → review+
Comment on attachment 8940609 [details]
Bug 1424271 - convert mochitest test_analyserNodePassThrough.html and test_analyserNodePassThrough.html to a web-platform-test

https://reviewboard.mozilla.org/r/210824/#review216730

This uses an API that is proprietary and that we use for the developers tools, we won't be importing this one.
Attachment #8940609 - Flags: review?(padenot) → review-
Comment on attachment 8940611 [details]
Bug 1424271 - convert mochitest test_audioBufferSourceNodeEnded.html to a web-platform-test

https://reviewboard.mozilla.org/r/210828/#review216732
Attachment #8940611 - Flags: review?(padenot) → review+
Comment on attachment 8940612 [details]
Bug 1424271 - convert mochitest test_audioBufferSourceNodeLazyLoopParam.html to a web-platform-test

https://reviewboard.mozilla.org/r/210830/#review216734
Attachment #8940612 - Flags: review?(padenot) → review+
Comment on attachment 8940613 [details]
Bug 1424271 - convert mochitest test_audioBufferSourceNodeLoop.html to a web-platform-test

https://reviewboard.mozilla.org/r/210832/#review216736
Attachment #8940613 - Flags: review?(padenot) → review+
Comment on attachment 8940615 [details]
Bug 1424271 - convert mochitest test_audioBufferSourceNodeLoopStartEndSame.html to a web-platform-test

https://reviewboard.mozilla.org/r/210836/#review216738
Attachment #8940615 - Flags: review?(padenot) → review+
Comment on attachment 8940616 [details]
Bug 1424271 - convert mochitest test_audioBufferSourceNodeOffset.html to a web-platform-test

https://reviewboard.mozilla.org/r/210838/#review216740

::: testing/web-platform/tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/test_audioBufferSourceNodeOffset.html:13
(Diff revision 1)
> +var fuzz = 0.3;
> +
> +if (navigator.platform.startsWith("Mac")) {
> +  // bug 895720
> +  fuzz = 0.6;
> +}

Not sure I like this too much. We should try pushing it without.
Attachment #8940616 - Flags: review?(padenot)
Comment on attachment 8940617 [details]
Bug 1424271 - convert mochitest test_AudioContext.html to a web-platform-test

https://reviewboard.mozilla.org/r/210840/#review216742
Attachment #8940617 - Flags: review?(padenot) → review+
Comment on attachment 8940618 [details]
Bug 1424271 - convert mochitest test_audioDestinationNode.html to a web-platform-test

https://reviewboard.mozilla.org/r/210842/#review216744
Attachment #8940618 - Flags: review?(padenot) → review+
Comment on attachment 8940620 [details]
Bug 1424271 - convert mochitest test_audioParamChaining.html to a web-platform-test

https://reviewboard.mozilla.org/r/210846/#review216748
Attachment #8940620 - Flags: review?(padenot) → review+

The bug assignee didn't login in Bugzilla in the last 7 months.
:padenot, could you have a look please?
For more information, please visit auto_nag documentation.

Assignee: alan.guyoch → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(padenot)
Flags: needinfo?(padenot)
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: