1424374 - DOM Cache API should consider using PromiseWindowProxy and weak-refs

Status: NEW

(Core :: Storage: Cache API, enhancement, P3)

Description

[Ben Kelly [:bkelly, not reviewing]]

Currently the DOM Cache API is holding strong refs to the promise, parent object, and global for every operation it performs:

https://searchfox.org/mozilla-central/source/dom/cache/CacheOpChild.h#75

We should investigate if we can make these weak and use the new PromiseWindowProxy.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Andrew, I was thinking about this a bit more and I actually started to think maybe every API that returns a Promise backed by some internal native operation should use PromiseWindowProxy.  If thats the case, though, maybe we should make Promise do that automatically?

For example, if we created a separate internal PromisePrivate structure then the Promise itself could have the weak reference to it and the window.

Fixing this in Promise itself would avoid having to roto-till a bunch of code through the tree and complicating the API.  What do you think?

Comment 2

[Andrew McCreight [:mccr8]]

(In reply to Ben Kelly [:bkelly] from comment #1)
> Fixing this in Promise itself would avoid having to roto-till a bunch of
> code through the tree and complicating the API.  What do you think?

That sounds reasonable. I don't know how Promises are used.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

I think nearly every DOM returned Promise is held alive by some system activity.  We rely on these being resolved at some point or at window close.  As we learned with the SW job queue that can fail.  So I think fixing this in the Promise class itself would be worth it.