1424469 - The Downloads view in the Library window doesn't get focus when opened

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Mohammed Al Shara]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20171207220423

Steps to reproduce:

press ctrl + J to focus the downloads list


Actual results:

NVDA says library. I need to press shift + tab to focus and read the list.


Expected results:

NVDA should focus and read the first item in the list.

Comment 1

[James Teh [:Jamie]]

Confirmed. Happens with both 32 bit and 64 bit.

Focus lands on the window element with id places. Instead, initial focus should be set to the richlistbox with id downloadsRichListBox.

I seem to recall that this is a regression, but it appears to be the case in 56 at least.

Comment 2

[James Teh [:Jamie]]

It seems I was incorrect about this being present in Firefox 56.

Last good revision: 5f192263de3e033c3849729724dd388a24dca21e
First bad revision: 56294c9668222e65593818b97b6c9cda4160db54
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5f192263de3e033c3849729724dd388a24dca21e&tochange=56294c9668222e65593818b97b6c9cda4160db54
The only change landed was for bug 1381411.

For reference, this is also being tracked by NVDA: https://github.com/nvaccess/nvda/issues/7779

Comment 3

[James Teh [:Jamie]]

Hi Paolo! Bug 1381411 seems to have broken initial focus in the Downloads Library view. STR:

1. Ensure you have at least one download in your list.
2. Ensure the Library window is closed.
3. Press control+j to open the Downloads Library window.
Expected: The Downloads list (id: downloadsRichListBox) should get focus.
Actual: It doesn't. Focus lands on the window (id: places).

Curiously, if the downloads list is empty, it *does* get focus as expected.

Any ideas as to how this might have regressed?

Comment 4

[:Paolo Amadini]

I don't know why this has regressed, but it should probably be fixed at some point.

Comment 6

[:Paolo Amadini]

I might find some time to look into this in the next few days.

Comment 7

[:Paolo Amadini]

Attachment: Bug 1424469 - The Downloads view in the Library window doesn't get focus when opened.

We have to keep track of the focused element while remove the richlistbox element temporarily.

Review commit: https://reviewboard.mozilla.org/r/216634/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216634/

Comment 8

[Marco Bonardo [:mak]]

Comment on attachment 8946648 [details]
Bug 1424469 - The Downloads view in the Library window doesn't get focus when opened.

https://reviewboard.mozilla.org/r/216634/#review222708

Thanks.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6aa2d7b4215e
The Downloads view in the Library window doesn't get focus when opened. r=mak

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/6aa2d7b4215e

Comment 11

[:Paolo Amadini]

Comment on attachment 8946648 [details]
Bug 1424469 - The Downloads view in the Library window doesn't get focus when opened.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1381411
[User impact if declined]: Comment 0
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: Comment 3
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Low risk
[Why is the change risky/not risky?]: Simple fix with low chance of making things worse
[String changes made/needed]: None

Comment 12

[James Teh [:Jamie]]

Verified fixed in Firefox 60.0a1 20180201220225.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8946648 [details]
Bug 1424469 - The Downloads view in the Library window doesn't get focus when opened.

Low-risk fix, let's get it in 59b7.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e83f82bb9962

Comment 15

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed using Firefox 59 beta 7 under Win 10 64-bit.