1424502 - Screenshot Tool and downloads.download() lose filename extension on renaming a file

Status: NEW

(Toolkit :: Downloads API, defect, P3)

Description

[unfry-bg]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20171123161455

Steps to reproduce:

1. Check 'Always ask you where to save files' in Firefox preferences.
2. Take a screenshot with Firefox's Screenshot Tool. Click arrow button to save the screenshot.
3. Rename the screenshot and save it.

All the extensions which use downloads.download({ saveAs: true }) share this behavior. Images will lose a filename extension if you rename them before saving.


Actual results:

Image (screenshot) loses its filename extension.


Expected results:

Image (screenshot) should keep its filename extension.

Comment 1

[:Paolo Amadini]

Does this happen also if file extensions are hidden in Windows Explorer?

Can you post a screenshot of the file picker dialog before and after the rename?

Comment 2

[unfry-bg]

(In reply to :Paolo Amadini from comment #1)
> Does this happen also if file extensions are hidden in Windows Explorer?
> 
> Can you post a screenshot of the file picker dialog before and after the
> rename?

Here is demo GIF (8Mb): http://armarium.org/image/XL8

Comment 3

[:Paolo Amadini]

Thank you, it looks like we're not specifying a default extension for the file picker in that case.

My guess is that this won't happen if file extensions are hidden in Windows Explorer, so it should mitigate the issue somewhat. We should still look into this at some point.

Comment 4

[Barry Chen]

Bug 1396280 would fix this.