1424516 - Empty button in about:addons

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Oriol Brufau [:Oriol]]

1. Install some add-on, e.g. https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/
2. Go to about:addons
3. Find the add-on and click "More"
4. Scroll to bottom.

Result: there is an empty button at the right of "Disable" and "Remove"
Expected: no empty button.

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cd942db65cf93dad9688937034ef7f8fb91e5379&tochange=2297e770f16c7411ff64dce3349a9406a59a9129

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1424516 Remove some overlooked addon purchasing bits

Review commit: https://reviewboard.mozilla.org/r/206872/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206872/

Comment 2

[Robert Helmer [:rhelmer]]

Comment on attachment 8936090 [details]
Bug 1424516 Remove some overlooked addon purchasing bits

https://reviewboard.mozilla.org/r/206872/#review212900

lgtm; if you are looking for other purchase-related bits to purge I see some in AddonRepository.jsm https://searchfox.org/mozilla-central/search?q=purchase&path=

Comment 3

[Andrew Swan [:aswan]]

> lgtm; if you are looking for other purchase-related bits to purge I see some
> in AddonRepository.jsm

I'm leaving AddonRepository.jsm alone for now, expecting to give it a pretty big overhaul in bug 1402064

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d4f22dea065
Remove some overlooked addon purchasing bits r=rhelmer

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/6d4f22dea065

Comment 6

[Petruta Horea [:phorea], Desktop Test Engineering]

Reproduced the issue while working on bug 1424013.

Verified as fixed on latest Nightly 59.0a1 2017-12-12 under Mac OS X 10.12, Ubuntu 14.04 64-bit and Win 10 64-bit.