Closed Bug 1424528 Opened 3 years ago Closed 3 years ago

Remove nsDidReflowStatus

Categories

(Core :: Layout, enhancement)

enhancement
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: mats, Assigned: mats)

Details

Attachments

(4 files)

No description provided.
We can remove it because nsDidReflowStatus::NOT_FINISHED is unused:
https://searchfox.org/mozilla-central/search?q=symbol:E_%3CT_nsDidReflowStatus%3E_NOT_FINISHED&redirect=false
(I'll squash these patches before landing.)
Comment on attachment 8936072 [details] [diff] [review]
part 1 - Remove nsDidReflowStatus::FINISHED 3rd arg in DidReflow calls (automated change)

Review of attachment 8936072 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8936072 - Flags: review?(dholbert) → review+
Comment on attachment 8936073 [details] [diff] [review]
part 2 - Remove nsDidReflowStatus param in DidReflow declarations (automated change)

Review of attachment 8936073 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8936073 - Flags: review?(dholbert) → review+
Comment on attachment 8936074 [details] [diff] [review]
part 3 - A few manual fixes related to removing the nsDidReflowStatus param in DidReflow

Review of attachment 8936074 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8936074 - Flags: review?(dholbert) → review+
Comment on attachment 8936075 [details] [diff] [review]
part 4 - Remove the nsDidReflowStatus enum type

Review of attachment 8936075 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8936075 - Flags: review?(dholbert) → review+
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eff49cd65526
part 1 - Remove nsDidReflowStatus::FINISHED 3rd arg in DidReflow calls (automated change).  r=dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4c652681897
part 2 - Remove nsDidReflowStatus param in DidReflow declarations (automated change).  r=dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/8fa2521be038
part 3 - A few manual fixes related to removing the nsDidReflowStatus param in DidReflow.  r=dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6be61a6cc39
part 4 - Remove the nsDidReflowStatus enum type.  r=dholbert
You need to log in before you can comment on or make changes to this bug.