Closed
Bug 1424552
Opened 6 years ago
Closed 6 years ago
Port |Bug 1423798 - Remove headers included for backwards compatibility in nsString.h| to mailnews
Categories
(MailNews Core :: Backend, enhancement)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 59.0
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
Details
Attachments
(1 file)
|
4.26 KB,
patch
|
Details | Diff | Splinter Review |
We get compile errors like: nsMsgIncomingServer.cpp:710:60: error: 'NS_FREE_XPCOM_ISUPPORTS_POINTER_ARRAY' was not declared in this scope and nsMsgAccountManager.cpp:296:68: error: 'NS_FREE_XPCOM_ALLOCATED_POINTER_ARRAY' was not declared in this scope The are defined in https://searchfox.org/mozilla-central/source/xpcom/base/nsMemory.h#106 which isn't included any more.
|
Assignee | |
Comment 1•6 years ago
|
||
Just need to add #include "nsMemory.h" in various files :-(
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•6 years ago
|
||
This compiles so far. I might wait or ship off a try which only takes 32 minutes to build these days on TC.
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/f2dde79f7e44 port bug 1423798 to mailnews: Add include of nsMemory.h where needed. rs=bustage-fix
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 59.0
Version: 52 → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•