1424601 - TB: Restore the Preferences bindings/styles after their removal in bug 1379338

Status: RESOLVED FIXED

(Thunderbird :: Preferences, enhancement)

Description

[Richard Marti (:Paenglab)]

Bug 1379338 removes bindings and styles for the windowed preferences. Because we still use them, we need to move them to c-c.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: prefBinding.patch

Jörg, bug 1379338 has no r+ yet but this can be in short time. I already r? you to be ready when it lands.

Stefan, are you okay with the common preferences.xml? Or do you want the preferences.css file with the binding declarations in common too?

Comment 2

[Stefan [:stefanh]]

Comment on attachment 8936128 [details] [diff] [review]
prefBinding.patch

Thanks for doing this. We don't declare the other migrated bindings in a common css file, so I think it's fine. We could later on consolidate into something similar to toolkit's xul.css if we want.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: prefBinding.patch

Thank you, Stefan.

Missed a removed rule in osx preferences.css.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: prefBinding.patch

Optimized some CSS (removed contrary code in the same file).

Sorry for the spam.

Comment 5

[Jorg K (CEST = GMT+2)]

There hasn't been any action in bug 1379338, hence no action here.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 8936143 [details] [diff] [review]
prefBinding.patch

Cancelling the review for now since bug 1379338 isn't moving. I'm watching that bug to reschedule the review, or please r? again once the other bug is close to being landed. Right now I can't action this patch.

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 8936143 [details] [diff] [review]
prefBinding.patch

Bug 1379338 is now in m-i

Comment 8

[Jorg K (CEST = GMT+2)]

Comment on attachment 8936143 [details] [diff] [review]
prefBinding.patch

Wow, what a big patch. So that's for preferences in a window, right?
Will we eventually remove those? Or is this waiting for "accounts in a tab"? :-(

rs=jorgk

Comment 9

[Richard Marti (:Paenglab)]

(In reply to Jorg K (GMT+1) from comment #8)
> Comment on attachment 8936143 [details] [diff] [review]
> prefBinding.patch
> 
> Wow, what a big patch. So that's for preferences in a window, right?
> Will we eventually remove those? Or is this waiting for "accounts in a tab"?

It's big because of preferences.xml.

For prefs in tab we'd need to rewrite them like FX has done.

I've set c-n but it should only land after bug 1379338 landing because packaging would fail with duplicate files (you could do this to check that preferences.xml isn't altered with moving to c-c ;) ).

Comment 10

[Richard Marti (:Paenglab)]

Bug 1379338 was backed out.

Comment 11

[Richard Marti (:Paenglab)]

And it's again in m-i.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/662f3ff6f50c
Restore the Preferences bindings/styles after their removal in toolkit in bug 1379338. rs=jorgk

Comment 13

[:aceman]

Why do they have to remove all the good stuff. The toolkit will stay a really dumb platforms and no toolkit.
So now all the preferences bindings and elements like <prefwindow> are adopted into c-c.
And it's not that Firefox wouldn't need these features, as can be seen in
https://bug1379338.bmoattachments.org/attachment.cgi?id=8940038 they just open-coded it and reimplemented in a different way via toolkit/content/preferencesBindings.js.

Thanks for the patch.